Proof Portal

Projects

jsonparser

ProbeLabs23 findings · 123 requirements
Showing the current git stateNo audit has been synced for this project yet — verification results (proof status, coverage, solver signals) appear once an audit is published.proof-demod79405e
All requirements
RequirementSYS-REQ-049SystemApproved

When Delete calls internalGet and internalGet returns an error, Delete shall use that error to short-circuit to the safe fallback path (return original input unchanged) rather than discarding the error and proceeding with potentially invalid offsets.

This requirement changed after its last recorded review, so approval is stale. Automated checks pass and 1/1 obligations are satisfied.
PriorityshallTypeguaranteeCategoryfunctionalComponentparserAssuranceEFindingsnone open

Specification

The requirement exactly as authored — its complete prose text and, where present, the formal FRETish sentence it compiles to.

Description

When Delete calls internalGet and internalGet returns an error, Delete shall use that error to short-circuit to the safe fallback path (return original input unchanged) rather than discarding the error and proceeding with potentially invalid offsets.

FRETish formula
the parser shall always satisfy !delete_discards_internalGet_error | delete_propagates_internalGet_error
View full formal model

Rationale & tags

Why this requirement exists, and how it is categorised.

Error propagation from internalGet is the defense-in-depth mechanism against sentinel-value panics. If Delete discards the error (assigns to _), it loses the signal that offsets are invalid. This was a contributing factor in the PR #280 class.

error-propagationdeletepr280

Verification & provenance

How this requirement was checked: the review trail, edit history, and the machine-analysis status terms (each ⓘ explains what it means).

Assurance levelE
Formalizationvalid
Strategyfretish

Review

Status
approved
Reviewer
Buger · lead_engineer
Reviewed
Aug 20, 2026, 13:11 UTC
Spec-conformance reviewed (agent:claude:spec-conformance); approved on owner authorization.

History

Created
Apr 14, 2026, 18:00 UTC · Claude · AI agent
Modified
Aug 20, 2026, 13:11 UTC · Buger

Change history

Every recorded revision of this requirement's source file — newest first, each with its commit message and the diff for that change.

Review history

Human and AI-agent approvals of this requirement — the 'why was this approved' lineage, each with the reviewer's justification and the code it cites.

  1. Claude:spec Conformance · AI agentApprovedSpec conformanceAug 20, 2026 · last monthREVIEW-31

    Every internalGetConfig call in the delete path checks the returned error and short-circuits to the safe fallback return data, false rather than proceeding with the returned offsets: the parent-path lookup (parser.go:1270-1273), the value-span lookup in the object branch (parser.go:1284-1286), and the full-path lookup in the array branch (parser.go:1320-1323). No branch discards the error and continues with the offsets, so invalid offsets can never drive the copy/slice at parser.go:1380-1382. MCDC Row3 propagated-error witness passes.

    Cited code (3)

Obligations

What this requirement must witness to be considered satisfied — the required evidence, and the tests that discharge each one.

1 obligation · 1 discharged

Browse the catalogue
Discharged
If it were violatedCritical

Delete discards the internalGet error and proceeds with stale offsets into data[prevTok]/data[end:] (parser.go:907), panicking with index-out-of-range on adversarial input — the OSS-Fuzz witness shape.

Discharging evidence1/1 required witnessed
  • nominalrequiredpresent
    Covered by 1 test

Formula evidence

The formal formula behind this requirement, the variables it is written over, and the tests that exercise it (each term is explained inline).

FRETish formula

the parser shall always satisfy !delete_discards_internalGet_error | delete_propagates_internalGet_error

Variables

NameTypeDirectionDescription
delete_discards_internalGet_errorTrue when Delete discards an error returned by internalGet (assigns to underscore) instead of using it to short-circuit.
delete_propagates_internalGet_errorTrue when Delete uses an error returned by internalGet to short-circuit to the safe fallback path.

Witnesses· 3 scenarios total

  • TestMCDC_SYS_REQ_049_Row1_TriggerFalse
    exercises 1 condition scenario
  • TestMCDC_SYS_REQ_049_Row2_InvariantViolation
    exercises 1 condition scenario
  • TestMCDC_SYS_REQ_049_Row3_PropagatedError
    exercises 1 condition scenario

MC/DC truth table· 3 rows

Each row assigns the formula's conditions (T/F) and shows the Result— the formula's value for that input row, not a test pass/fail. A row proves a condition when flipping only that condition flips the outcome. The test that covers each row is linked.

Covereda test exercises this rowExempteda reviewed mcdc:ignoreNo-actionfalse-result row satisfied by designUncoveredneeds a covering test
#delete_discards_internalGet_errordelete_propagates_internalGet_errorResultProvesCovering test
1FFTdelete_discards_internalGet_error
2TFFdelete_discards_internalGet_error
3TTTdelete_propagates_internalGet_error

Its place

How this requirement connects — what proves it, what it affects, and what it rests on. Authored links only here; automatically derived links come from the audit index.

Loading graph…

Trace evidence

The concrete artifacts linked to this requirement — implementing code, verifying tests, documents, and the findings raised against it.

Impact

Blast radius — authored trace links only (automatically derived links come from the audit index and aren't shown here).

If you change this

Requirements
0
Files
1
Tests
3
At-risk contracts
0

Files to re-check (1)

  • parser.goparser.go

Tests to re-run (3)

  • deep_spec_test.godeep_spec_test.go
  • mcdc_spec_witnesses_test.gomcdc_spec_witnesses_test.go
  • obligation_evidence_test.goobligation_evidence_test.go

What this rests on

Changes

Semantic changes that move or scope this requirement — the intended work touching it. Each links to the full change.

Discussions

Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.

Sign in to discuss this with the proof team.Sign in