Proof Portal

Project overview

Omarchy

ProbeLabsviewing a historical run

A proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.

Viewing historical run cd52be1Sep 29, 2026, 09:37 AMpr/13511Back to current
Back to findings
Problem reportDEFECT-260927-CMMA

String-blind trailing-comma strip silently mutated in-string commas in menu labels and actions

FixedFixedMedium

This defect has been fixed and verified.

Closure: Hazard class closed
Verified by 2 regression tests

Description

The issue as recorded.

MenuModel.js stripJsonc used the string-blind regex /,(\s*[}\]])/g to strip JSONC trailing commas. The regex matched zero-width whitespace and never tracked string literals. It deleted in-string commas before a closer even though those commas were data. JSON.parse accepted the stripped text, so the corruption stayed silent. Mode (a) corrupted display labels; mode (b) mutated action commands such as "mv f{.bak,}" brace expansions. omarchy-menu runs action strings with full user privileges, so mutated commands executed without warning.

Affected requirements

The requirement(s) this issue violates — click through to the spec.

Severity, explained

Why this is rated the way it is — and the scoring signals behind the rating (each ⓘ explains the term).

MediumRated severity — the impact if this issue is exploited or hit.
risk area
Config Behavior

Where it is

The code this defect touches — peek any of these files inline to see the exact spot.

Root cause

What actually went wrong underneath — how it is classified, and the coverage gap that let it slip through.

No requirement modeled the comma-drop decision. Its two conditions (comma_in_string, next_char_closes_json) had no exercising test. No test partition held a comma plus closer inside a string literal. 3T3F could not catch this class because the corrupted text still parsed.

defect class: Missing ValidationSpec gap— this behaviour wasn't specified
Why this escaped
Missing requirementMissing MC/DC variableMissing test partition

Disposition: Covered by a requirement

Proof it's fixed

The tests, tightened requirements and new obligations that prove this defect is gone — and can't quietly return.

Covered by a requirement.

verified by
test/shell.d/menu-test.shtest/node/menumodel-replay.test.mjs
regression tests
test/shell.d/menu-test.shtest/node/menumodel-replay.test.mjs
strengthened requirements
New proof obligations

Blast radius

If you touch this issue, what else may need re-checking — the requirements it affects and the code and tests that hang off them. Historical view: authored trace links only — automatically derived links aren't reconstructible for past runs.

No authoredcode links reach these requirements in this historical reconstruction. Automatically derived code links aren't reconstructible for past runs, so implementing code may have existed without an authored trace.

Tracing blast radius…

Change history

Every recorded revision of this finding's source file — when it was added, edited, or re-classified, with the diff for each change.

Discussions

Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.

Sign in to discuss this with the proof team.Sign in