Proof Portal

Project overview

Omarchy

ProbeLabsviewing a historical run

A proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.

Viewing historical run 5e89718Oct 2, 2026, 03:13 AMpr/13968Back to current
Back to findings
Problem reportDEFECT-260927-CMMA

String-blind trailing-comma strip silently mutated in-string commas in menu labels and actions

FixedFixedMedium

This defect has been fixed and verified.

Closure: Hazard class closed
Verified by 2 regression tests

Description

The issue as recorded.

MenuModel.js stripJsonc used the string-blind regex /,(\s*[}\]])/g to strip JSONC trailing commas. The regex matched zero-width whitespace and never tracked string literals. It deleted in-string commas before a closer even though those commas were data. JSON.parse accepted the stripped text, so the corruption stayed silent. Mode (a) corrupted display labels; mode (b) mutated action commands such as "mv f{.bak,}" brace expansions. omarchy-menu runs action strings with full user privileges, so mutated commands executed without warning.

Affected requirements

The requirement(s) this issue violates — click through to the spec.

Severity, explained

Why this is rated the way it is — and the scoring signals behind the rating (each ⓘ explains the term).

MediumRated severity — the impact if this issue is exploited or hit.
risk area
Config Behavior

Where it is

The code this defect touches — peek any of these files inline to see the exact spot.

Root cause

What actually went wrong underneath — how it is classified, and the coverage gap that let it slip through.

No requirement modeled the comma-drop decision. Its two conditions (comma_in_string, next_char_closes_json) had no exercising test. No test partition held a comma plus closer inside a string literal. 3T3F could not catch this class because the corrupted text still parsed.

defect class: Missing ValidationSpec gap— this behaviour wasn't specified
Why this escaped
Missing requirementMissing MC/DC variableMissing test partition

Disposition: Covered by a requirement

Proof it's fixed

The tests, tightened requirements and new obligations that prove this defect is gone — and can't quietly return.

Covered by a requirement.

verified by
regression tests
strengthened requirements
New proof obligations

Blast radius

If you touch this issue, what else may need re-checking — the requirements it affects and the code and tests that hang off them. Historical view: authored trace links only — automatically derived links aren't reconstructible for past runs.

Tracing blast radius…

Touch this finding and you re-check 10 requirements · 2 code files · 3 tests.

Code files (2)
  • Menu.qml
  • MenuModel.js
Tests (3)
  • menumodel-replay.test.mjs
  • menu-test.sh
  • menu-pointer-lifecycle-test.sh

Per-requirement evidence

For each requirement this finding touches: the implementing code, verifying tests, and proof obligations that discharge it.

Implementing code (3)
  • shell/plugins/menu/Menu.qml
    item
  • shell/plugins/menu/MenuModel.js
    parseMenuJsonc
  • shell/plugins/menu/MenuModel.js
    stripJsonc
Tests & evidence (2)
  • test/node/menumodel-replay.test.mjs
  • test/shell.d/menu-test.sh
Proof obligations (3)
boundary

Behavior at limits, thresholds, and edge-of-range values.

  • ✓nominal (required) — test/shell.d/menu-test.sh:138
  • ✓negative — test/node/menumodel-replay.test.mjs:159, test/shell.d/menu-test.sh:152
error_handling

Behavior when operations fail or dependencies are unavailable.

  • ✓negative (required) — test/node/menumodel-replay.test.mjs:1339, test/shell.d/menu-test.sh:132
  • ✓nominal (required) — test/shell.d/menu-test.sh:64
input_domain

A parser, reader, or configuration loader states its accepted input domain at the byte level and what happens for each partition of it.

  • ✓nominal (required) — test/shell.d/menu-test.sh:338
  • ✓negative — test/shell.d/menu-test.sh:330
Implementing code (3)
  • shell/plugins/menu/Menu.qml
    item
  • shell/plugins/menu/MenuModel.js
    parseMenuJsonc
  • shell/plugins/menu/MenuModel.js
    stripJsonc
Tests & evidence (2)
  • test/node/menumodel-replay.test.mjs
  • test/shell.d/menu-test.sh
Proof obligations (1)
input_domain

A parser, reader, or configuration loader states its accepted input domain at the byte level and what happens for each partition of it.

  • ✓nominal (required) — test/shell.d/menu-test.sh:300, test/shell.d/menu-test.sh:305, test/shell.d/menu-test.sh:315, test/shell.d/menu-test.sh:323, test/shell.d/menu-test.sh:342
  • ✓negative — test/shell.d/menu-test.sh:333
Tests & evidence (2)
  • test/node/menumodel-replay.test.mjs
  • test/shell.d/menu-test.sh
Proof obligations (2)
boundary

Behavior at limits, thresholds, and edge-of-range values.

  • ✓nominal (required) — test/shell.d/menu-test.sh:138, test/node/menumodel-replay.test.mjs:1353
  • ✓negative — test/node/menumodel-replay.test.mjs:159, test/shell.d/menu-test.sh:152
error_handling

Behavior when operations fail or dependencies are unavailable.

  • ✓negative (required) — test/node/menumodel-replay.test.mjs:1339, test/shell.d/menu-test.sh:132, test/node/menumodel-replay.test.mjs:1352
  • ✓nominal (required) — test/shell.d/menu-test.sh:64

Change history

Every recorded revision of this finding's source file — when it was added, edited, or re-classified, with the diff for each change.

Discussions

Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.

Sign in to discuss this with the proof team.Sign in