Proof Portal
Omarchy
ProbeLabsviewing a historical runA proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.
Top-level JSON array root in menu JSONC rendered phantom rows id 0,1,...
This defect has been fixed and verified.
Description
The issue as recorded.
MenuModel.js parseMenuJsonc guarded the parsed root with a typeof check. But typeof [] is "object", so a JSON array root passed the guard. The for..in loop then iterated array indices and emitted phantom rows with numeric ids parented to root. A phantom row carries the label and action out of its array element. Activating it ran a command the user never placed in the menu with full user privileges. JSON.parse accepted the input, so no error surfaced.
Affected requirements
The requirement(s) this issue violates — click through to the spec.
Severity, explained
Why this is rated the way it is — and the scoring signals behind the rating (each ⓘ explains the term).
- risk area
- Config Behavior
Where it is
The code this defect touches — peek any of these files inline to see the exact spot.
Root cause
What actually went wrong underneath — how it is classified, and the coverage gap that let it slip through.
No requirement modeled the root-type decision. Its condition (array_root_present) had no exercising test. The malformed-input partition held scalars (null, 42, "str") but no array root. 3T3F could not catch this class because the array still parsed. Reproduced on the pristine quattro baseline ce925cb1 with review/upstream-repro-jsonc-toplevel-array.js (rc=1).
Disposition: Covered by a requirement
Proof it's fixed
The tests, tightened requirements and new obligations that prove this defect is gone — and can't quietly return.
Covered by a requirement.
- Malformed Input on SW-REQ-260928-BMFE
Blast radius
If you touch this issue, what else may need re-checking — the requirements it affects and the code and tests that hang off them. Historical view: authored trace links only — automatically derived links aren't reconstructible for past runs.
Touch this finding and you re-check 10 requirements · 2 code files · 3 tests.
- Menu.qml
- MenuModel.js
- menumodel-replay.test.mjs
- menu-test.sh
- menu-pointer-lifecycle-test.sh
Per-requirement evidence
For each requirement this finding touches: the implementing code, verifying tests, and proof obligations that discharge it.
Per-requirement evidence
For each requirement this finding touches: the implementing code, verifying tests, and proof obligations that discharge it.
Change history
Every recorded revision of this finding's source file — when it was added, edited, or re-classified, with the diff for each change.
Discussions
Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.