Proof Portal
Omarchy
ProbeLabsviewing a historical runA proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.
Inline JSONC comment tail survived stripping and emptied the whole menu
This defect has been fixed and verified.
Description
The issue as recorded.
MenuModel.js stripJsonc stripped only whole-line comments with a line-anchored regex. An inline comment tail after content survived stripping. JSON.parse then rejected the whole file and the catch returned an empty item set. One trailing comment emptied the entire menu. No error surfaced because the catch swallows the parse failure by design. Reproduced on the pristine quattro baseline ce925cb1 with review/upstream-repro-jsonc-inline-comment.js (rc=1).
Affected requirements
The requirement(s) this issue violates — click through to the spec.
Severity, explained
Why this is rated the way it is — and the scoring signals behind the rating (each ⓘ explains the term).
- risk area
- Config Behavior
Where it is
The code this defect touches — peek any of these files inline to see the exact spot.
Root cause
What actually went wrong underneath — how it is classified, and the coverage gap that let it slip through.
No requirement modeled the comment-strip decision. Its condition (comment_in_string) had no exercising test. The comment partition held whole-line comments but no inline tail. 3T3F could not catch this class because the parse failure returns an empty set by design.
Disposition: Covered by a requirement
Proof it's fixed
The tests, tightened requirements and new obligations that prove this defect is gone — and can't quietly return.
Covered by a requirement.
- Malformed Input on SW-REQ-260928-C8W1
Blast radius
If you touch this issue, what else may need re-checking — the requirements it affects and the code and tests that hang off them. Historical view: authored trace links only — automatically derived links aren't reconstructible for past runs.
Touch this finding and you re-check 8 requirements · 2 code files · 1 tests.
- Menu.qml
- MenuModel.js
- menu-test.sh
Per-requirement evidence
For each requirement this finding touches: the implementing code, verifying tests, and proof obligations that discharge it.
Per-requirement evidence
For each requirement this finding touches: the implementing code, verifying tests, and proof obligations that discharge it.
Change history
Every recorded revision of this finding's source file — when it was added, edited, or re-classified, with the diff for each change.
Discussions
Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.