Proof Portal
Omarchy
ProbeLabsviewing a historical runA proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.
Map reads walk Object.prototype: item(), results maps, providersLoaded treat constructor/toString as real entries
Low-severity issue, currently open.
Description
The issue as recorded.
item() is a raw truthy read (items[id] ? ... : null), so inherited prototype properties look up as menu rows (probe F7). They beat aliases in resolveRoute, defeat the root fallback in openExistingMenu/setActiveMenu, and mark provider menus already-loaded (loadProviderForMenu's providersLoaded truthiness, SX26/C21). The same class hits results maps: isDisabled/labelFor read disabledResults[id] off a fresh {} and get the inherited function. They dim and check-mark a row whose id collides (HFY2/C16).
Affected requirements
The requirement(s) this issue violates — click through to the spec.
Severity, explained
Why this is rated the way it is — and the scoring signals behind the rating (each ⓘ explains the term).
- why this rating
- Risk-rated
- risk area
- Correctness
- CVE surface
- None
How it's proven
The reproducer — an actual test that drives the real code and shows the issue happening. Run it yourself, or peek the test and the source it covers.
known_issue_reproducernode pocs/menu-probes.js ../shell/plugins/menu/MenuModel.js
Reproduction steps
Technical steps for your engineers to confirm the issue by hand.
node pocs/menu-probes.js ../shell/plugins/menu/MenuModel.js
What protects you, and the fix
What limits your exposure today, and the planned remediation.
What protects you now
requires a menu id that collides with an Object.prototype name - user-authored JSONC can do this
The fix
hasOwnProperty checks (or null-prototype maps / Object.hasOwn) at every dynamic map read: item(), results lookups, providersLoaded
Blast radius
If you touch this issue, what else may need re-checking — the requirements it affects and the code and tests that hang off them. Historical view: authored trace links only — automatically derived links aren't reconstructible for past runs.
Touch this finding and you re-check 2 requirements · 2 code files · 2 tests.
- MenuModel.js
- Menu.qml
- menu-test.sh
- menu-compositor-test.sh
Per-requirement evidence
For each requirement this finding touches: the implementing code, verifying tests, and proof obligations that discharge it.
Per-requirement evidence
For each requirement this finding touches: the implementing code, verifying tests, and proof obligations that discharge it.
Evidence trail
The raw evidence manifests behind this finding — superseded by the resolved reproducer above, kept here for traceability.
Evidence trail
The raw evidence manifests behind this finding — superseded by the resolved reproducer above, kept here for traceability.
- pocs/menu-probes.js
- pocs/menu-probes2.js
- pocs/menu-probes3.js
- proof/evidence/ki-menu-item-prototype-leak.yaml
Change history
Every recorded revision of this finding's source file — when it was added, edited, or re-classified, with the diff for each change.
Discussions
Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.