Proof Portal

Sign in
Project overview

Omarchy

ProbeLabsviewing a historical run

A proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.

Viewing historical run 59d5325Oct 2, 2026, 08:10 PMpr/10631Back to current
Back to findings
Known issueKI-MENU-JSONC-ARRAY-ROOT

parseMenuJsonc reads a top-level JSON array as entries with ids 0, 1, … (omacom/omarchy#13492)

OpenOpenLow

Low-severity issue, currently open.

What this means for you

Plain-language impact — what this issue could mean for your users and your system, before any of the technical detail.

If a menu file's top level is a list instead of an object, the menu silently reads the list as entries. Items with an action appear under their own labels, items without one stay hidden, and no error says the file has the wrong shape. The shipped menu is not affected; only a hand-edited file written as a list hits this.

Technical description

parseMenuJsonc (shell/plugins/menu/MenuModel.js:44-66) rejects scalar and null roots only. typeof [] is "object", so an array root reaches the for..in loop. The loop iterates the array indices. Each object element becomes a row with id "0", "1", ... under root, with the label and action of the element. The default file and the user extension file use the same parser, and mergeMenuSources merges both. Upstream issue: omacom/omarchy#13492. Report intake validated it (report cmulr8j7z0hy31gw4pne8v6u4).

Affected requirements

The requirement(s) this issue violates — click through to the spec.

SW-REQ-260922-3T3F

Severity, explained

Why this is rated the way it is — and the scoring signals behind the rating (each ⓘ explains the term).

LowRated severity — the impact if this issue is exploited or hit.
why this rating
Risk-rated
risk area
Correctness
Security classification
Not a security surface
CVE surface
None

Where it is

The code the issue lives in — peek the affected function inline to see it in context.

  • MenuModel.parseMenuJsonc root-type guard

How it's proven

The reproducer — an actual test that drives the real code and shows the issue happening. Run it yourself, or peek the test and the source it covers.

Known issue reproducedprofileknown_issue_reproducerprovesSW-REQ-260922-3T3F
Reproducer test
Run it yourself
sh test/reports/report-cmulr8j7z0hy31gw4pne8v6u4.sh
Covers (2)
Last run Oct 2, 2026, 5:09 PM

Reproduction steps

Technical steps for your engineers to confirm the issue by hand.

sh test/reports/report-cmulr8j7z0hy31gw4pne8v6u4.sh

What protects you, and the fix

What limits your exposure today, and the planned remediation.

What protects you now

The trigger is a menu file with an array root, which the documented format never uses. Label-only elements stay hidden; elements with an action show under the user's own labels, so nothing tells the user the file is wrong.

The fix

Reject an array root like the scalar roots, as omacom/omarchy#13968 does with an Array.isArray guard (requirement SW-REQ-260928-BMFE in the proof layer).

Blast radius

If you touch this issue, what else may need re-checking — the requirements it affects and the code and tests that hang off them. Historical view: authored trace links only — automatically derived links aren't reconstructible for past runs.

Tracing blast radius…

Touch this finding and you re-check 1 requirements · 2 code files · 2 tests.

Requirements (1)
SW-REQ-260922-3T3F
Code files (2)
  • Menu.qml
  • MenuModel.js
Tests (2)
  • menumodel-replay.test.mjs
  • menu-test.sh

Per-requirement evidence

For each requirement this finding touches: the implementing code, verifying tests, and proof obligations that discharge it.

SW-REQ-260922-3T3F
Implementing code (3)
  • shell/plugins/menu/Menu.qml
    parseMenuJsonc
  • shell/plugins/menu/MenuModel.js
    parseMenuJsonc
  • shell/plugins/menu/MenuModel.js
    stripJsonc
Tests & evidence (2)
  • test/node/menumodel-replay.test.mjs
  • test/shell.d/menu-test.sh
Proof obligations (3)
boundary

Behavior at limits, thresholds, and edge-of-range values.

  • ✓nominal (required) — test/shell.d/menu-test.sh:98
  • ✓negative — test/node/menumodel-replay.test.mjs:120, test/shell.d/menu-test.sh:113
error_handling

Behavior when operations fail or dependencies are unavailable.

  • ✓negative (required) — test/node/menumodel-replay.test.mjs:1048, test/shell.d/menu-test.sh:92
  • ✓nominal (required) — test/shell.d/menu-test.sh:64
input_domain

A parser, reader, or configuration loader states its accepted input domain at the byte level and what happens for each partition of it.

  • ✓nominal (required) — test/shell.d/menu-test.sh:293
  • ✓negative — test/shell.d/menu-test.sh:287

Evidence trail

The raw evidence manifests behind this finding — superseded by the resolved reproducer above, kept here for traceability.

  • proof/evidence/ki-menu-jsonc-array-root.yaml

Change history

Every recorded revision of this finding's source file — when it was added, edited, or re-classified, with the diff for each change.

Discussions

Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.

Sign in to discuss this with the proof team.Sign in