Proof Portal
Omarchy
ProbeLabsviewing a historical runA proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.
parseMenuJsonc walks a top-level JSON array and renders phantom rows keyed 0, 1, ... (omacom/omarchy#13492)
Low-severity issue, currently open.
Description
The issue as recorded.
parseMenuJsonc (shell/plugins/menu/MenuModel.js:44-66) rejects scalar and null roots only. typeof [] is "object", so an array root reaches the for..in loop. The loop iterates the array indices. Each object element becomes a row with id "0", "1", ... under root, with the label and action of the element.
The default file and the user extension file use the same parser, and mergeMenuSources merges both. Upstream issue: omacom/omarchy#13492. Report intake validated it (report cmulr8j7z0hy31gw4pne8v6u4).
Affected requirements
The requirement(s) this issue violates — click through to the spec.
Severity, explained
Why this is rated the way it is — and the scoring signals behind the rating (each ⓘ explains the term).
- why this rating
- Risk-rated
- risk area
- Correctness
- CVE surface
- None
Where it is
The code the issue lives in — peek the affected function inline to see it in context.
- MenuModel.parseMenuJsonc root-type guard
How it's proven
The reproducer — an actual test that drives the real code and shows the issue happening. Run it yourself, or peek the test and the source it covers.
sh test/reports/report-cmulr8j7z0hy31gw4pne8v6u4.sh
Reproduction steps
Technical steps for your engineers to confirm the issue by hand.
sh test/reports/report-cmulr8j7z0hy31gw4pne8v6u4.sh
What protects you, and the fix
What limits your exposure today, and the planned remediation.
What protects you now
The trigger is a menu file with an array root, and the documented format never uses one. The phantom rows show in the root menu, so the user sees that the file is wrong
The fix
Reject an array root like the scalar roots, as omacom/omarchy#13968 does with an Array.isArray guard (SW-REQ-260928-BMFE on its proof mirror).
Blast radius
If you touch this issue, what else may need re-checking — the requirements it affects and the code and tests that hang off them. Historical view: authored trace links only — automatically derived links aren't reconstructible for past runs.
Touch this finding and you re-check 1 requirements · 2 code files · 2 tests.
- Menu.qml
- MenuModel.js
- menumodel-replay.test.mjs
- menu-test.sh
Per-requirement evidence
For each requirement this finding touches: the implementing code, verifying tests, and proof obligations that discharge it.
Per-requirement evidence
For each requirement this finding touches: the implementing code, verifying tests, and proof obligations that discharge it.
Evidence trail
The raw evidence manifests behind this finding — superseded by the resolved reproducer above, kept here for traceability.
Evidence trail
The raw evidence manifests behind this finding — superseded by the resolved reproducer above, kept here for traceability.
- proof/evidence/ki-menu-jsonc-array-root.yaml
Change history
Every recorded revision of this finding's source file — when it was added, edited, or re-classified, with the diff for each change.
Discussions
Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.