Proof Portal

Sign in
Project overview

Omarchy

ProbeLabsviewing a historical run

A proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.

Viewing historical run ac92b86Oct 2, 2026, 02:11 AMpr/6525Back to current
Back to findings
Known issueKI-MENU-JSONC-COMMENT-INDENT-WHITESPACE

A comment line indented with Unicode or control whitespace empties the menu file under PR #6525

OpenOpenLow

Low-severity issue, currently open.

Description

The issue as recorded.

With omacom/omarchy#6525, stripJsonc (shell/plugins/menu/MenuModel.js) drops a // comment with a scanner instead of the old line-anchored regex ^\s*\/\/. The regex removed a whole-line comment together with any JS whitespace in front of it. JS \s also matches VT, FF, U+00A0, U+1680, U+2000 to U+200A, U+2028, U+2029, U+202F, U+205F, U+3000 and U+FEFF. The scanner drops only the comment and keeps that character. JSON.parse accepts only space, tab, LF and CR as whitespace. So a full-line comment indented with one of those characters now makes the whole file fail to parse. The catch returns an empty item set, and the PR's new console.warn logs the parse error. On the baseline the same file parses to all of its entries. We checked this with the real MenuModel.js at the PR head merged onto the baseline. pocs/pr6525-comment-indent-whitespace.sh shows it for all 21 characters against an ASCII-indented control. Quickshell's FileView drops a byte-order mark at the very start of the file. So under the shell a leading BOM before a header comment does not trigger it. The same character on any later line does.

Affected requirements

The requirement(s) this issue violates — click through to the spec.

SW-REQ-260922-E4J2

Severity, explained

Why this is rated the way it is — and the scoring signals behind the rating (each ⓘ explains the term).

LowRated severity — the impact if this issue is exploited or hit.
why this rating
Risk-rated
risk area
Correctness
Security classification
Not a security surface
CVE surface
None

Where it is

The code the issue lives in — peek the affected function inline to see it in context.

  • MenuModel.parseMenuJsoncdefault and user menu JSONC

How it's proven

The reproducer — an actual test that drives the real code and shows the issue happening. Run it yourself, or peek the test and the source it covers.

Known issue reproducedprofileknown_issue_reproducerprovesSW-REQ-260922-E4J2
Reproducer test
Run it yourself
sh pocs/pr6525-comment-indent-whitespace.sh
Covers (2)
Last run Oct 2, 2026, 1:52 AM

Reproduction steps

Technical steps for your engineers to confirm the issue by hand.

sh pocs/pr6525-comment-indent-whitespace.sh

What protects you, and the fix

What limits your exposure today, and the planned remediation.

What protects you now

Indent comment lines in the menu file with ASCII spaces or tabs only. The shipped default menu indents with ASCII spaces.

The fix

In the scanner, copy any JS whitespace character outside a string as one ASCII space, and keep line feeds. Then the indentation the old regex removed is still accepted. omacom/omarchy#13968 does this in its second commit b2dae8db.

Blast radius

If you touch this issue, what else may need re-checking — the requirements it affects and the code and tests that hang off them. Historical view: authored trace links only — automatically derived links aren't reconstructible for past runs.

Tracing blast radius…

Touch this finding and you re-check 1 requirements · 2 code files · 2 tests.

Requirements (1)
SW-REQ-260922-E4J2
Code files (2)
  • Menu.qml
  • MenuModel.js
Tests (2)
  • menumodel-replay.test.mjs
  • menu-test.sh

Per-requirement evidence

For each requirement this finding touches: the implementing code, verifying tests, and proof obligations that discharge it.

SW-REQ-260922-E4J2
Implementing code (3)
  • shell/plugins/menu/Menu.qml
    item
  • shell/plugins/menu/MenuModel.js
    parseMenuJsonc
  • shell/plugins/menu/MenuModel.js
    stripJsonc
Tests & evidence (2)
  • test/node/menumodel-replay.test.mjs
  • test/shell.d/menu-test.sh
Proof obligations (1)
input_domain

A parser, reader, or configuration loader states its accepted input domain at the byte level and what happens for each partition of it.

  • ✓nominal (required) — test/shell.d/menu-test.sh:268, test/shell.d/menu-test.sh:286, test/shell.d/menu-test.sh:294
  • ✓negative — test/shell.d/menu-test.sh:311

Evidence trail

The raw evidence manifests behind this finding — superseded by the resolved reproducer above, kept here for traceability.

  • proof/evidence/ki-menu-jsonc-comment-indent-whitespace.yaml

Change history

Every recorded revision of this finding's source file — when it was added, edited, or re-classified, with the diff for each change.

Discussions

Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.

Sign in to discuss this with the proof team.Sign in