Proof Portal

Sign in
Project overview

Omarchy

ProbeLabs73 findings · 87 requirements

A proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.

Back to findings
Known issueKI-MENU-JSONC-INLINE-COMMENT

stripJsonc removes only whole-line // comments; an inline comment tail empties the whole file (omacom/omarchy#13493)

OpenOpenLow

Low-severity issue, currently open.

What this means for you

Plain-language impact — what this issue could mean for your users and your system, before any of the technical detail.

One // comment after content on a line, for example after an entry, makes the whole menu file unreadable, so every entry in it disappears: all of your own additions in the extension file, or the whole menu in the default file. Nothing in the menu or the journal says why. Comments on their own line work, and no data is changed.

Technical description

The stripJsonc comment pass (shell/plugins/menu/MenuModel.js:4) matches only at the start of a line. A // comment after content on the same line stays in the text. JSON.parse then rejects the file, and parseMenuJsonc returns no rows. One inline note in the user extension drops every user entry; in the default file it drops every row. docs/menu.md documents this limitation. Upstream issue: omacom/omarchy#13493. Report intake validated it (report cmulr8j7w0hy01gw4menggvbx).

Affected requirements

The requirement(s) this issue violates — click through to the spec.

SW-REQ-260922-E4J2

Severity, explained

Why this is rated the way it is — and the scoring signals behind the rating (each ⓘ explains the term).

LowRated severity — the impact if this issue is exploited or hit.
why this rating
Risk-rated
risk area
Correctness
Security classification
Not a security surface
CVE surface
None

Where it is

The code the issue lives in — peek the affected function inline to see it in context.

  • MenuModel.parseMenuJsonc / stripJsonc whole-line comment pass

How it's proven

The reproducer — an actual test that drives the real code and shows the issue happening. Run it yourself, or peek the test and the source it covers.

Known issue reproducedprofileknown_issue_reproducerprovesSW-REQ-260922-E4J2
Reproducer test
Run it yourself
sh test/reports/report-cmulr8j7w0hy01gw4menggvbx.sh
Covers (2)
Last run Oct 2, 2026, 5:24 PM

Reproduction steps

Technical steps for your engineers to confirm the issue by hand.

sh test/reports/report-cmulr8j7w0hy01gw4menggvbx.sh

What protects you, and the fix

What limits your exposure today, and the planned remediation.

What protects you now

docs/menu.md documents the limitation, and comments on their own line work. The missing entries are visible, but nothing in the menu or the journal says why; nothing changes the user's data.

The fix

Strip a // comment wherever its opener sits outside a string, without breaking the trailing-comma-then-comment-line shape, as omacom/omarchy#13968 does (requirement SW-REQ-260928-C8W1 in the proof layer). The earlier single-pass attempt (omacom/omarchy#13512, closed) broke that shape; #13968 supersedes it.

Blast radius

If you touch this issue, what else may need re-checking — the requirements it affects and the code and tests that hang off them. Historical view: authored trace links only — automatically derived links aren't reconstructible for past runs.

Tracing blast radius…

Touch this finding and you re-check 1 requirements · 2 code files · 2 tests.

Requirements (1)
SW-REQ-260922-E4J2
Code files (2)
  • Menu.qml
  • MenuModel.js
Tests (2)
  • menumodel-replay.test.mjs
  • menu-test.sh

Per-requirement evidence

For each requirement this finding touches: the implementing code, verifying tests, and proof obligations that discharge it.

SW-REQ-260922-E4J2
Implementing code (4)
  • shell/plugins/menu/Menu.qml
    parseMenuJsonc
  • shell/plugins/menu/Menu.qml
    stripJsonc
  • shell/plugins/menu/MenuModel.js
    parseMenuJsonc
  • shell/plugins/menu/MenuModel.js
    stripJsonc
Tests & evidence (2)
  • test/node/menumodel-replay.test.mjs
  • test/shell.d/menu-test.sh
Proof obligations (1)
input_domain

A parser, reader, or configuration loader states its accepted input domain at the byte level and what happens for each partition of it.

  • ✓nominal (required) — test/shell.d/menu-test.sh:257, test/shell.d/menu-test.sh:262, test/shell.d/menu-test.sh:272, test/shell.d/menu-test.sh:280
  • ✓negative — test/shell.d/menu-test.sh:297

Evidence trail

The raw evidence manifests behind this finding — superseded by the resolved reproducer above, kept here for traceability.

  • proof/evidence/ki-menu-jsonc-inline-comment.yaml

Change history

Every recorded revision of this finding's source file — when it was added, edited, or re-classified, with the diff for each change.

Discussions

Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.

Sign in to discuss this with the proof team.Sign in