Proof Portal
Omarchy
ProbeLabs73 findings · 87 requirementsA proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.
stripJsonc has no block-comment pass: a /* */ comment empties the whole file
Low-severity issue, currently open.
Description
The issue as recorded.
Upstream stripJsonc (shell/plugins/menu/MenuModel.js:2-6) removes whole-line // comments and trailing commas only. A /* */ block comment stays in the text. JSON.parse rejects it, and parseMenuJsonc returns an empty item set for an otherwise valid menu file. docs/menu.md documents whole-line // comments only, so block comments are outside the documented grammar, but nothing tells the user why their entries disappeared. omacom/omarchy#13968 keeps block comments unsupported and documents that, so this issue stays open after it lands. CR-only line endings and non-ASCII whitespace are separate issues (KI-MENU-JSONC-CR-LINE-ENDINGS, KI-MENU-JSONC-UNICODE-WHITESPACE).
Affected requirements
The requirement(s) this issue violates — click through to the spec.
Severity, explained
Why this is rated the way it is — and the scoring signals behind the rating (each ⓘ explains the term).
- why this rating
- Risk-rated
- risk area
- Correctness
- CVE surface
- None
How it's proven
The reproducer — an actual test that drives the real code and shows the issue happening. Run it yourself, or peek the test and the source it covers.
sh pocs/menu-jsonc-block-comment.sh
Reproduction steps
Technical steps for your engineers to confirm the issue by hand.
sh pocs/menu-jsonc-block-comment.sh
What protects you, and the fix
What limits your exposure today, and the planned remediation.
What protects you now
Block comments are outside the grammar that docs/menu.md documents (whole-line // comments only). The failure is visible because the entries of the file disappear
The fix
Add a string-aware block-comment pass ahead of the comma pass, or document block comments as unsupported
Blast radius
If you touch this issue, what else may need re-checking — the requirements it affects and the code and tests that hang off them. Historical view: authored trace links only — automatically derived links aren't reconstructible for past runs.
Touch this finding and you re-check 1 requirements · 2 code files · 2 tests.
- Menu.qml
- MenuModel.js
- menumodel-replay.test.mjs
- menu-test.sh
Per-requirement evidence
For each requirement this finding touches: the implementing code, verifying tests, and proof obligations that discharge it.
Per-requirement evidence
For each requirement this finding touches: the implementing code, verifying tests, and proof obligations that discharge it.
Evidence trail
The raw evidence manifests behind this finding — superseded by the resolved reproducer above, kept here for traceability.
Evidence trail
The raw evidence manifests behind this finding — superseded by the resolved reproducer above, kept here for traceability.
- pocs/menu-jsonc-block-comment.sh
- proof/evidence/ki-menu-jsonc-strip-gaps.yaml
Change history
Every recorded revision of this finding's source file — when it was added, edited, or re-classified, with the diff for each change.
Discussions
Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.