Proof Portal

Sign in
Project overview

Omarchy

ProbeLabsviewing a historical run

A proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.

Viewing historical run e797ba5Sep 30, 2026, 11:40 PMquattroBack to current
Back to findings
Known issueKI-MENU-JSONC-STRIP-GAPS

stripJsonc parser gaps: comma behind a // comment survives, // eats the newline, block comments and CR pass through

OpenOpenLow

Low-severity issue, currently open.

Description

The issue as recorded.

stripJsonc (shell/plugins/menu/MenuModel.js:2-37) drops a comma only when the next non-whitespace char is }/]. So a // comment between them keeps the comma and JSON.parse rejects the file. The // eater consumes through end-of-line WITHOUT keeping the newline, gluing adjacent tokens ([1//c\n2] parses as [12]). Block comments /* */ have no branch and the stripper copies them through. A // comment under CR-only line endings eats to the next LF or EOF. Each corruption makes parseMenuJsonc return an empty item set for a valid JSONC menu.

Affected requirements

The requirement(s) this issue violates — click through to the spec.

SW-REQ-260922-E4J2SW-REQ-260922-3T3F

Severity, explained

Why this is rated the way it is — and the scoring signals behind the rating (each ⓘ explains the term).

LowRated severity — the impact if this issue is exploited or hit.
why this rating
Risk-rated
risk area
Correctness
Security classification
Not a security surface
CVE surface
None

How it's proven

The reproducer — an actual test that drives the real code and shows the issue happening. Run it yourself, or peek the test and the source it covers.

Known issue reproducedprofileknown_issue_reproducer
Reproducer test
Run it yourself
node pocs/menu-probes.js ../shell/plugins/menu/MenuModel.js
Covers (2)
Last run Sep 30, 2026, 11:02 PM

Reproduction steps

Technical steps for your engineers to confirm the issue by hand.

node pocs/menu-probes.js ../shell/plugins/menu/MenuModel.js

What protects you, and the fix

What limits your exposure today, and the planned remediation.

What protects you now

a whole-file comment or comma-shape already breaks the menu (parse returns []), which is visible

The fix

strip only the comment bytes, preserving the line break; add a block-comment branch; treat CR as a line terminator

Blast radius

If you touch this issue, what else may need re-checking — the requirements it affects and the code and tests that hang off them. Historical view: authored trace links only — automatically derived links aren't reconstructible for past runs.

Tracing blast radius…

Touch this finding and you re-check 2 requirements · 2 code files · 1 tests.

Requirements (2)
SW-REQ-260922-E4J2SW-REQ-260922-3T3F
Code files (2)
  • Menu.qml
  • MenuModel.js
Tests (1)
  • menu-test.sh

Per-requirement evidence

For each requirement this finding touches: the implementing code, verifying tests, and proof obligations that discharge it.

SW-REQ-260922-E4J2
Implementing code (3)
  • shell/plugins/menu/Menu.qml
    item
  • shell/plugins/menu/MenuModel.js
    parseMenuJsonc
  • shell/plugins/menu/MenuModel.js
    stripJsonc
Tests & evidence (1)
  • test/shell.d/menu-test.sh
SW-REQ-260922-3T3F
Implementing code (3)
  • shell/plugins/menu/Menu.qml
    item
  • shell/plugins/menu/MenuModel.js
    parseMenuJsonc
  • shell/plugins/menu/MenuModel.js
    stripJsonc
Tests & evidence (1)
  • test/shell.d/menu-test.sh
Proof obligations (2)
boundary

Behavior at limits, thresholds, and edge-of-range values.

  • ✓nominal (required) — test/shell.d/menu-test.sh:98
  • ✓negative — test/shell.d/menu-test.sh:109
error_handling

Behavior when operations fail or dependencies are unavailable.

  • ✓negative (required) — test/shell.d/menu-test.sh:92
  • ✓nominal (required) — test/shell.d/menu-test.sh:64

Evidence trail

The raw evidence manifests behind this finding — superseded by the resolved reproducer above, kept here for traceability.

  • pocs/menu-probes.js
  • pocs/menu-probes2.js
  • pocs/menu-probes3.js
  • proof/evidence/ki-menu-jsonc-strip-gaps.yaml

Change history

Every recorded revision of this finding's source file — when it was added, edited, or re-classified, with the diff for each change.

Discussions

Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.

Sign in to discuss this with the proof team.Sign in