Proof Portal

Project overview

Omarchy

ProbeLabs65 findings · 95 requirements

A proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.

Inbox
ReportR-4988GitHub issuePublicReceived

Bug: Array.isArray fails on manifest.kinds QJSValue, causing PluginShellApi revocation for 3rd-party menu plugins

Reported by ankardo · filed Sep 9, 2026Closed upstream on 2026-09-20 by bjarneo via an automated message, as a duplicate of #10661 (R-860). GitHub close reason: completed.

Received and recorded verbatim. Nothing has been checked yet.

At a glance

1 · What is claimed?
Only the report text below — no validator has restated it as checkable claims yet.
2 · What does it affect?
Not yet mapped to any requirement or component.
3 · Is it reproducible?
No validation has been run yet.
4 · What remains unclear?
  • Not validated yet: no claims, no reproducer.
5 · What happens next?
Our staff decide whether the report is valid. Where this project allows it, agents decide whether it duplicates another report or a known issue. No decision has been recorded yet.

Original report

Bug: Array.isArray fails on manifest.kinds QJSValue, causing PluginShellApi revocation for 3rd-party menu pluginsrevision 1 · captured 2026-10-04 12:10 UTC via poll

Description

When a third-party clone of a menu plugin is loaded (e.g., omarchy.menu cloned to ankardo.menu with kinds: ["menu", "bar-widget"]), the Omarchy shell incorrectly revokes its PluginShellApi shortly after instantiation, causing injected properties like root.shell to become null. This breaks access to appLibrary and completely empties the app list.

Root Cause

The bug is located in shell.qml in the manifestHasKind function:

  function manifestHasKind(manifest, kind) {
    return !!manifest && Array.isArray(manifest.kinds)
      && manifest.kinds.indexOf(kind) !== -1
  }

When manifest is read from an Instantiator's modelData (as is the case with panelEntry.manifest passed to pluginShellFor), the Qt/QML engine wraps the underlying JS Array inside a QJSValue or QVariant. Consequently, Array.isArray(manifest.kinds) incorrectly returns false.

This false evaluation cascades into pluginShellCapabilityProfile, calculating an unexpected profile (e.g. own-service|no-bar|no-indicators|no-menu), which mismatches the original profile descriptor. The mismatch triggers shell.revokePluginShellApi(shellKey), destroying the C++ API wrapper.

Proposed Fix

Avoid using strict Array.isArray() on objects originating from QML models. Duck-typing such as checking manifest.kinds.length > 0 works correctly across QJSValue boundaries:

  function manifestHasKind(manifest, kind) {
    return !!manifest && manifest.kinds && manifest.kinds.length > 0
      && manifest.kinds.indexOf(kind) !== -1
  }

Steps to Reproduce

  1. Clone omarchy.menu using omarchy menu plugin clone omarchy.menu
  2. Set the newly cloned plugin active on the bar.
  3. Open the menu. Observe that the app list is entirely empty because appLibrary cannot be accessed (since root.shell was set to null).

System Info

  • Omarchy version: 4.0.3-1
View raw text
### Description

When a third-party clone of a menu plugin is loaded (e.g., `omarchy.menu` cloned to `ankardo.menu` with `kinds: ["menu", "bar-widget"]`), the Omarchy shell incorrectly revokes its `PluginShellApi` shortly after instantiation, causing injected properties like `root.shell` to become `null`. This breaks access to `appLibrary` and completely empties the app list.

### Root Cause

The bug is located in `shell.qml` in the `manifestHasKind` function:

```javascript
  function manifestHasKind(manifest, kind) {
    return !!manifest && Array.isArray(manifest.kinds)
      && manifest.kinds.indexOf(kind) !== -1
  }
```

When `manifest` is read from an `Instantiator`'s `modelData` (as is the case with `panelEntry.manifest` passed to `pluginShellFor`), the Qt/QML engine wraps the underlying JS Array inside a `QJSValue` or `QVariant`. Consequently, `Array.isArray(manifest.kinds)` incorrectly returns `false`.

This false evaluation cascades into `pluginShellCapabilityProfile`, calculating an unexpected profile (e.g. `own-service|no-bar|no-indicators|no-menu`), which mismatches the original profile descriptor. The mismatch triggers `shell.revokePluginShellApi(shellKey)`, destroying the C++ API wrapper.

### Proposed Fix

Avoid using strict `Array.isArray()` on objects originating from QML models. Duck-typing such as checking `manifest.kinds.length > 0` works correctly across QJSValue boundaries:

```javascript
  function manifestHasKind(manifest, kind) {
    return !!manifest && manifest.kinds && manifest.kinds.length > 0
      && manifest.kinds.indexOf(kind) !== -1
  }
```

### Steps to Reproduce
1. Clone `omarchy.menu` using `omarchy menu plugin clone omarchy.menu`
2. Set the newly cloned plugin active on the bar.
3. Open the menu. Observe that the app list is entirely empty because `appLibrary` cannot be accessed (since `root.shell` was set to `null`).

### System Info
- Omarchy version: 4.0.3-1

Validation

Not checked yet. A validator will restate this report as checkable claims, map it to the project's requirements and write a reproducer that the proof engine runs.

Linked

Not linked to any known issue, other report or change yet.

Decision

Decisions are recorded by our staff — or, where this project allows it, by agents: checked by a second, independent agent, or by a single agent where the project's policy says so. Any decision reached so far is shown below.

No decision has been recorded yet.