Proof Portal

Project overview

Omarchy

ProbeLabs65 findings · 95 requirements

A proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.

Inbox
ReportR-687GitHub issuePublicDecided· Out of scope

omarchy plugin disable <unknown-id> silently succeeds instead of erroring like enable does

Reported by brenoperucchi · filed Sep 11, 2026 · open at source

Decided: Out of scope — decided by agents · verified 3 days ago.

At a glance

1 · What is claimed?
Only the report text below — no validator has restated it as checkable claims yet.
2 · What does it affect?
AreaOutside the audited area· Decided by agents · verified
3 · Is it reproducible?
No validation has been run yet.
4 · What remains unclear?
  • Not validated yet: no claims, no reproducer.
5 · What happens next?
Decided by agents and verified by a second, independent agent — see the decision.

Original report

omarchy plugin disable <unknown-id> silently succeeds instead of erroring like enable doesrevision 1 · captured 2026-09-28 21:23 UTC via poll

What's wrong

omarchy plugin disable <unknown-id> exits 0 and reports success without disabling anything, unlike omarchy plugin enable <unknown-id>, which fails loudly with the correct error message. A user who typos a plugin id (or copies one from stale documentation — this is exactly how I found it, via a third-party plugin's README) gets told the plugin was disabled when it was not, and has no indication anything went wrong.

Reproduced against a real installed plugin (macos.dock) with a typo'd id:

$ omarchy plugin enable ifubaraboye.dock
omarchy-plugin-enable: plugin 'ifubaraboye.dock' is not known; run: omarchy-shell shell rescanPlugins

$ omarchy plugin disable ifubaraboye.dock
Disabled ifubaraboye.dock

$ omarchy plugin list | grep dock
macos.dock                       enabled   third-party panel              macOS Style Dock

enable refuses correctly. disable claims success against an id that has never existed, and the real plugin (macos.dock) stays enabled throughout — the command that looked like it worked did nothing at all.

Root cause

PluginRegistry.setEnabled() (shell/services/PluginRegistry.qml) validates the manifest only on the enable path:

function setEnabled(id, value, placement) {
    var key = Util.canonicalWidgetId(String(id))
    lastEnableError = ""
    if (!shellConfigMutator) {
      console.warn("PluginRegistry.setEnabled called before shellConfigMutator wired")
      return false
    }
    var manifest = installedPlugins[key]
    if (value && !manifest) {
      console.warn("PluginRegistry.setEnabled: unknown plugin " + key)
      return false
    }
    ...

if (value && !manifest) only fires when value is true (enabling). For value = false (disabling), an unknown id skips this guard entirely and falls through to the same code path a real, currently-enabled plugin would take, which apparently still reports success.

The two CLI scripts show the same asymmetry one level up. omarchy-plugin-enable checks for both outcomes:

result=$(omarchy-shell shell enablePlugin "$id" "$placement")
if [[ $result == "unknown" ]]; then
  fail "plugin '$id' is not known; run: omarchy-shell shell rescanPlugins"
elif [[ $result != "ok" ]]; then
  fail "$result"
fi

omarchy-plugin-disable only checks for one:

result=$(omarchy-shell shell setPluginEnabled "$id" false)
[[ $result == "ok" ]] ||
  fail "plugin '$id' is not known; run: omarchy-shell shell rescanPlugins"

The shell.qml IPC handler behind it already returns the right signal for this exact case, so the fix looks like it lives in PluginRegistry.setEnabled() alone:

function setPluginEnabled(id: string, enabled: string): string {
  return shell.pluginRegistry.setEnabled(id, enabled === "true") ? "ok" : "unknown"
}

Suggested fix

Change the guard in setEnabled() from if (value && !manifest) to if (!manifest), so both enable and disable reject an unrecognized id the same way. omarchy-plugin-disable's existing [[ $result == "ok" ]] || fail ... already produces the right message once setEnabled returns false for this case — no CLI-side change needed.

Environment

Omarchy 4.0.3-1, quickshell 0.3.1-1.

View raw text
## What's wrong

`omarchy plugin disable <unknown-id>` exits 0 and reports success without disabling anything, unlike `omarchy plugin enable <unknown-id>`, which fails loudly with the correct error message. A user who typos a plugin id (or copies one from stale documentation — this is exactly how I found it, via a third-party plugin's README) gets told the plugin was disabled when it was not, and has no indication anything went wrong.

Reproduced against a real installed plugin (`macos.dock`) with a typo'd id:

```
$ omarchy plugin enable ifubaraboye.dock
omarchy-plugin-enable: plugin 'ifubaraboye.dock' is not known; run: omarchy-shell shell rescanPlugins

$ omarchy plugin disable ifubaraboye.dock
Disabled ifubaraboye.dock

$ omarchy plugin list | grep dock
macos.dock                       enabled   third-party panel              macOS Style Dock
```

`enable` refuses correctly. `disable` claims success against an id that has never existed, and the real plugin (`macos.dock`) stays enabled throughout — the command that looked like it worked did nothing at all.

## Root cause

`PluginRegistry.setEnabled()` (`shell/services/PluginRegistry.qml`) validates the manifest only on the enable path:

```qml
function setEnabled(id, value, placement) {
    var key = Util.canonicalWidgetId(String(id))
    lastEnableError = ""
    if (!shellConfigMutator) {
      console.warn("PluginRegistry.setEnabled called before shellConfigMutator wired")
      return false
    }
    var manifest = installedPlugins[key]
    if (value && !manifest) {
      console.warn("PluginRegistry.setEnabled: unknown plugin " + key)
      return false
    }
    ...
```

`if (value && !manifest)` only fires when `value` is `true` (enabling). For `value = false` (disabling), an unknown id skips this guard entirely and falls through to the same code path a real, currently-enabled plugin would take, which apparently still reports success.

The two CLI scripts show the same asymmetry one level up. `omarchy-plugin-enable` checks for both outcomes:

```bash
result=$(omarchy-shell shell enablePlugin "$id" "$placement")
if [[ $result == "unknown" ]]; then
  fail "plugin '$id' is not known; run: omarchy-shell shell rescanPlugins"
elif [[ $result != "ok" ]]; then
  fail "$result"
fi
```

`omarchy-plugin-disable` only checks for one:

```bash
result=$(omarchy-shell shell setPluginEnabled "$id" false)
[[ $result == "ok" ]] ||
  fail "plugin '$id' is not known; run: omarchy-shell shell rescanPlugins"
```

The `shell.qml` IPC handler behind it already returns the right signal for this exact case, so the fix looks like it lives in `PluginRegistry.setEnabled()` alone:

```qml
function setPluginEnabled(id: string, enabled: string): string {
  return shell.pluginRegistry.setEnabled(id, enabled === "true") ? "ok" : "unknown"
}
```

## Suggested fix

Change the guard in `setEnabled()` from `if (value && !manifest)` to `if (!manifest)`, so both enable and disable reject an unrecognized id the same way. `omarchy-plugin-disable`'s existing `[[ $result == "ok" ]] || fail ...` already produces the right message once `setEnabled` returns `false` for this case — no CLI-side change needed.

## Environment

Omarchy 4.0.3-1, quickshell 0.3.1-1.

Validation

Not checked yet. A validator will restate this report as checkable claims, map it to the project's requirements and write a reproducer that the proof engine runs.

Linked

Not linked to any known issue, other report or change yet.

Decision

Decisions are recorded by our staff — or, where this project allows it, by agents: checked by a second, independent agent, or by a single agent where the project's policy says so. Any decision reached so far is shown below.

  • Out of scopeDecided by agents · verified · 2026-10-09 11:45 UTC