Proof Portal
Omarchy
ProbeLabsviewing a historical runA proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.
Unparseable input (after stripping), non-object JSON, and non-object entries yield an empty or skipped item set; no exception escapes the parser.
Specification
The requirement exactly as authored — its complete prose text and, where present, the formal FRETish sentence it compiles to.
Unparseable input (after stripping), non-object JSON, and non-object entries yield an empty or skipped item set; no exception escapes the parser. Trailing-comma stripping is string-aware. It preserves commas inside string literals verbatim. It drops only a comma outside any string whose next non-whitespace character is } or ] (trailing_comma_dropped = !comma_in_string && next_char_closes_json).
when json_invalid the menu_model shall eventually satisfy empty_item_set & !parse_error_raised
Rationale & tags
Why this requirement exists, and how it is categorised.
Rationale & tags
Why this requirement exists, and how it is categorised.
MenuModel.js parseMenuJsonc and stripJsonc. A crashing parser would take the whole menu down on a user edit. The pre-fix string-blind comma regex silently corrupted labels such as "x, ]y" while the parse still succeeded.
Verification & provenance
How this requirement was checked: the review trail, edit history, and the machine-analysis status terms (each ⓘ explains what it means).
Review
- Status
- in_review
- Reviewer
- Kimi Zero Warnings · AI agent
- Reviewed
- Sep 28, 2026, 00:00 UTC
History
- Created
- Sep 22, 2026, 13:34 UTC · Kimi Dogfood · AI agent
- Modified
- Sep 28, 2026, 00:00 UTC · Kimi Zero Warnings · AI agent
Hazard review
- scenarioreviewedmalformed_inputerror_handling
Delta-touched by the fix branch: description and rationale now name string-aware comma semantics. malformed_input: unparseable-after-strip input still routes to the unconditional catch returning []. Verified by direct execution on 2026-09-27: unterminated string -> parse fail -> empty set, no exception escapes. error_handling: the failure mode is silent empty menu by design. 66FW's prevention handles the subclass where parse SUCCEEDED on corrupted text, not error handling here.
- propertyrevieweddeterminism
- domainnot applicable
No domain workload tags; local config parser.
- structuralnot applicable
GC'd JavaScript; no C-family structural hazard surface.
Change history
Every recorded revision of this requirement's source file — newest first, each with its commit message and the diff for that change.
Review history
Human and AI-agent approvals of this requirement — the 'why was this approved' lineage, each with the reviewer's justification and the code it cites.
- Kimi Fix Jsonc Refresh · AI agentApprovedSpec conformanceSep 27, 2026 · 5 days agoREVIEW-22
Delta-touch conformance for the fix branch: agent-25 extended the description and rationale to name the string-aware trailing-comma semantics (trailing_comma_dropped = !comma_in_string && next_char_closes_json) and the pre-fix silent-corruption behavior. Verified against MenuModel.js: the stripJsonc scanner drops a comma iff it is outside every string literal and the next non-whitespace byte is } or ], and parseMenuJsonc still routes any post-strip parse failure to the catch that returns [] with no exception escaping (fretish: json_invalid -> eventually empty_item_set & !parse_error_raised unchanged and still honored; unterminated-string case verified by direct execution this campaign). The added prose is descriptive, not normative; the normative equivalence lives in SW-REQ-260927-66FW. Status promoted draft -> review on 2026-09-28 by agent:kimi-zero-warnings after the defect_review stamp gained verified:2 (CRS-0017/C03 array-root claim closed by SW-REQ-260928-BMFE; CRS-0017/C01 inline-comment claim closed by SW-REQ-260928-C8W1), which put this spec into the branch changed set.
Cited code (5)
Obligations
What this requirement must witness to be considered satisfied — the required evidence, and the tests that discharge each one.
2 obligations
Browse the catalogueDischarging tests pending a synced audit.
Discharging tests pending a synced audit.
Formula evidence
The formal formula behind this requirement, the variables it is written over, and the tests that exercise it (each term is explained inline).
Formula evidence
The formal formula behind this requirement, the variables it is written over, and the tests that exercise it (each term is explained inline).
FRETish formula
when json_invalid the menu_model shall eventually satisfy empty_item_set & !parse_error_raised
Witnesses· 2 scenarios total
- menu-test.sh:1exercises 2 condition scenarios
MC/DC truth table· 4 rows
Each row assigns the formula's conditions (T/F) and shows the Result— the formula's value for that input row, not a test pass/fail. A row proves a condition when flipping only that condition flips the outcome. The test that covers each row is linked.
mcdc:ignoreNo-actionfalse-result row satisfied by designUncoveredneeds a covering test| # | empty_item_set | json_invalid | parse_error_raised | Result | Proves | Covering test |
|---|---|---|---|---|---|---|
| 1 | F | F | F | T | json_invalid | |
| 2 | F | T | F | F | empty_item_set | — |
| 3 | T | T | F | T | empty_item_set | |
| 4 | T | T | T | F | parse_error_raised | — |
Its place
How this requirement connects — what proves it, what it affects, and what it rests on. Authored links only here; automatically derived links come from the audit index.
Loading graph…
Trace evidence
The concrete artifacts linked to this requirement — implementing code, verifying tests, documents, and the findings raised against it.
0 open · 3 resolved
No open findings
Everything flagged against this requirement has been resolved.
Resolved / historical (3)
- MediumFixed
String-blind trailing-comma strip silently mutated in-string commas in menu labels and actions
DEFECT-260927-CMMA
- MediumFixed
Top-level JSON array root in menu JSONC rendered phantom rows id 0,1,...
DEFECT-260928-4NG9
- MediumFixed
Inline JSONC comment tail survived stripping and emptied the whole menu
DEFECT-260928-7AX9
Impact
Blast radius — authored trace links only (automatically derived links come from the audit index and aren't shown here).
Impact
Blast radius — authored trace links only (automatically derived links come from the audit index and aren't shown here).
If you change this
Nothing downstream depends on this yet
No downstream impact — "Unparseable input (after stripping), non-object JSON, and…" has no downstream edges.
What this rests on
Discussions
Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.