Proof Portal
Omarchy
ProbeLabsviewing a historical runA proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.
The parser strips // comments and trailing commas outside string literals before JSON parsing, so the authored JSONC parses to its declared entries.
Specification
The requirement exactly as authored — its complete prose text and, where present, the formal FRETish sentence it compiles to.
The parser strips // comments and trailing commas outside string literals before JSON parsing, so the authored JSONC parses to its declared entries.
when jsonc_has_comments_or_commas the menu_model shall eventually satisfy items_parsed
Rationale & tags
Why this requirement exists, and how it is categorised.
Rationale & tags
Why this requirement exists, and how it is categorised.
MenuModel.js stripJsonc (a single string-aware scanner under PR omacom/omarchy#13968) and parseMenuJsonc. Three child requirements state the scanner rules: SW-REQ-260927-66FW (commas), SW-REQ-260928-C8W1 (comments) and SW-REQ-261001-BNZG (accepted characters and whitespace).
Verification & provenance
How this requirement was checked: the review trail, edit history, and the machine-analysis status terms (each ⓘ explains what it means).
Review
- Status
- in_review
- Reviewer
- Kimi Zero Warnings · AI agent
- Reviewed
- Sep 27, 2026, 21:25 UTC
History
- Created
- Sep 22, 2026, 13:34 UTC · Kimi Dogfood · AI agent
- Modified
- Oct 1, 2026, 22:40 UTC · Claude Pr 13968 · AI agent
Hazard review
- scenarioreviewedmalformed_inputboundaryedge_caseinput_domain
PR omacom/omarchy#13968 review (2026-10-01). stripJsonc is one string-aware scanner: string contents are copied verbatim, a // comment outside a string is dropped up to but not including its line break, a comma is dropped only when the next character that is neither whitespace nor part of a // comment is } or ], and any other JS \s character outside a string is passed on as a space (a line feed stays a line feed). Worst case: the stripper mangles authored content into different JSON, so the file parses to silently wrong entries (a comma or // inside a string eaten, as the upstream regexes did - #13250), or a correct file is rejected (an inline tail - #13493; a trailing comma before a commented-out entry - the #13512 regression; a byte order mark or Unicode space - the regression in the PR's first commit ff77cd02, fixed by its second commit b2dae8db). The controls are the decomposed rules SW-REQ-260927-66FW, SW-REQ-260928-C8W1 and SW-REQ-261001-BNZG with their witnesses, the preservation tests (incl. the shipped extension template with its examples uncommented) and the seeded differential test against an independent reference model in test/node/menumodel-replay.test.mjs. Block comments stay unsupported (KI-MENU-JSONC-STRIP-GAPS). boundary: end of input inside a comment or a string ends the pass without error; a file that strips to whitespace yields []; a comma at end of input is kept. edge_case: an escaped quote or an escaped backslash inside a string, a whole-line comment with an unbalanced quote, CRLF line endings, and a comment between two tokens (the line break keeps them apart). Catalog 1.11.0 re-review: input_domain applied, input_domain is on its obligation checklist: LF, CRLF, comment indentation with any JS whitespace, any character inside strings and huge files are accepted. With this PR any JS whitespace character between tokens is read as a space (SW-REQ-261001-BNZG), which fixes KI-MENU-JSONC-UNICODE-WHITESPACE. A CR-only file with a whole-line comment still empties the menu (KI-MENU-JSONC-CR-LINE-ENDINGS); this PR does not change it. concurrency_scale not applicable, a pure function of its arguments, recomputed on each load or keystroke: no state across calls, no process, timer or lock.
- propertyrevieweddeterminism
The strip is a single left-to-right pass with two states (in a string, outside), so one input yields one output every time. The same authored file parses to the same entries on every load, including the file watcher's reloads.
- structuralnot applicable
Character-classified string concatenation in a bounded single pass; no memory management, pointer math, or numeric surface, and no encoding transform - bytes pass through verbatim outside the two strip rules.
- domainnot applicable
The parser consumes the two fixed local menu JSONC paths (same-user, no egress sink in the traced files), and the parse-failure recovery policy (empty list, defaults preserved) is owned by the failure-arm siblings (3T3F/66FW), so no domain class binds to the strip contract reviewed here.
Change history
Every recorded revision of this requirement's source file — newest first, each with its commit message and the diff for that change.
Review history
Human and AI-agent approvals of this requirement — the 'why was this approved' lineage, each with the reviewer's justification and the code it cites.
- Kimi Zero Warnings · AI agentApprovedSpec conformanceSep 27, 2026 · 5 days agoREVIEW-48
Read stripJsonc (the function this branch fixed). Full-line // comments are stripped first, then trailing commas are removed string-aware: commas inside string literals copy verbatim (with backslash-escape handling) and a comma outside strings is dropped only when the next non-whitespace char is } or ]. The jsonc_has_comments_or_commas condition models both transforms; the string-awareness is the 66FW decision closing DEFECT-260927-CMMA. Formula conforms to the code.
Cited code (1)
Open known issues
Findings currently open against this requirement — issues its verification surfaced that are not resolved yet. Each links to the full finding.
- LowOpen
A flat menu containing an entry id 'items' is parsed as a wrapper and every sibling entry is silently discarded
KI-MENU-ITEMS-KEY-AMBIGUITY
- LowOpen
A whole-line comment in a CR-only menu file swallows the rest of the file
KI-MENU-JSONC-CR-LINE-ENDINGS
- LowOpen
stripJsonc has no block-comment pass: a /* */ comment empties the whole file
KI-MENU-JSONC-STRIP-GAPS
+6 resolved — see the Findings tab under Trace evidence.
Obligations
What this requirement must witness to be considered satisfied — the required evidence, and the tests that discharge each one.
1 obligation · 1 discharged
Browse the catalogueA parser, reader, or configuration loader states its accepted input domain at the byte level and what happens for each partition of it.
- nominalrequiredpresentCovered by 5 tests
- negativerecommendedpresentCovered by 1 test
Formula evidence
The formal formula behind this requirement, the variables it is written over, and the tests that exercise it (each term is explained inline).
Formula evidence
The formal formula behind this requirement, the variables it is written over, and the tests that exercise it (each term is explained inline).
FRETish formula
when jsonc_has_comments_or_commas the menu_model shall eventually satisfy items_parsed
Witnesses· 3 scenarios total
- menu-test.sh:1exercises 3 condition scenarios
MC/DC truth table· 3 rows
Each row assigns the formula's conditions (T/F) and shows the Result— the formula's value for that input row, not a test pass/fail. A row proves a condition when flipping only that condition flips the outcome. The test that covers each row is linked.
mcdc:ignoreNo-actionfalse-result row satisfied by designUncoveredneeds a covering test| # | items_parsed | jsonc_has_comments_or_commas | Result | Proves | Covering test |
|---|---|---|---|---|---|
| 1 | F | F | T | jsonc_has_comments_or_commas | |
| 2 | F | T | F | items_parsed | |
| 3 | T | T | T | items_parsed |
Its place
How this requirement connects — what proves it, what it affects, and what it rests on. Authored links only here; automatically derived links come from the audit index.
Loading graph…
Trace evidence
The concrete artifacts linked to this requirement — implementing code, verifying tests, documents, and the findings raised against it.
3 open · 6 resolved
- LowOpen
A flat menu containing an entry id 'items' is parsed as a wrapper and every sibling entry is silently discarded
KI-MENU-ITEMS-KEY-AMBIGUITY
- LowOpen
A whole-line comment in a CR-only menu file swallows the rest of the file
KI-MENU-JSONC-CR-LINE-ENDINGS
- LowOpen
stripJsonc has no block-comment pass: a /* */ comment empties the whole file
KI-MENU-JSONC-STRIP-GAPS
Resolved / historical (6)
- MediumFixed
stripJsonc comma regex rewrites strings that carry a comma before } or ] (omacom/omarchy#13250)
KI-MENU-JSONC-COMMA-IN-STRING
- MediumFixed
Unicode or control whitespace between JSONC tokens empties the whole menu file
KI-MENU-JSONC-UNICODE-WHITESPACE
- MediumFixed
String-blind trailing-comma strip silently mutated in-string commas in menu labels and actions
DEFECT-260927-CMMA
- MediumFixed
Top-level JSON array root in menu JSONC rendered phantom rows id 0,1,...
DEFECT-260928-4NG9
- MediumFixed
Inline JSONC comment tail survived stripping and emptied the whole menu
DEFECT-260928-7AX9
- LowFixed
stripJsonc removes only whole-line // comments; an inline comment tail empties the whole file (omacom/omarchy#13493)
KI-MENU-JSONC-INLINE-COMMENT
Impact
Blast radius — authored trace links only (automatically derived links come from the audit index and aren't shown here).
Impact
Blast radius — authored trace links only (automatically derived links come from the audit index and aren't shown here).
If you change this
Files to re-check (2)
- Menu.qmlshell/plugins/menu/Menu.qml
- MenuModel.jsshell/plugins/menu/MenuModel.js
Tests to re-run (3)
- menumodel-replay.test.mjstest/node/menumodel-replay.test.mjs
- report-cmulr8l6h0i461gw40vqqv64c.shtest/reports/report-cmulr8l6h0i461gw40vqqv64c.sh
- menu-test.shtest/shell.d/menu-test.sh
What this rests on
Discussions
Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.