Proof Portal

Project overview

Omarchy

ProbeLabsviewing a historical run

A proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.

Viewing historical run c0a4a03Oct 2, 2026, 01:01 AMpr/9056Back to current
All requirements
RequirementSW-REQ-260922-E4J2SoftwareReview

The parser strips full-line // comments and trailing commas before JSON parsing, so the authored JSONC parses to its declared entries.

This requirement changed after its last recorded review, so approval is stale. Automated checks pass.
PriorityshallTypeguaranteeCategoryfunctionalComponentmenuAssuranceCFindingsMediumworst open

Specification

The requirement exactly as authored — its complete prose text and, where present, the formal FRETish sentence it compiles to.

Description

The parser strips full-line // comments and trailing commas before JSON parsing, so the authored JSONC parses to its declared entries.

FRETish formula
when jsonc_has_comments_or_commas the menu_model shall eventually satisfy items_parsed
View full formal model

Rationale & tags

Why this requirement exists, and how it is categorised.

MenuModel.js stripJsonc lines 1-5 and parseMenuJsonc lines 42-64.

Verification & provenance

How this requirement was checked: the review trail, edit history, and the machine-analysis status terms (each ⓘ explains what it means).

Assurance levelC
Formalizationvalid
Realizabilityrealizable
Vacuitychecked_ok
Strategyfretish

Review

Status
in_review
Reviewer
Kimi Zero Warnings · AI agent
Reviewed
Sep 27, 2026, 21:25 UTC

History

Created
Sep 22, 2026, 13:34 UTC · Kimi Dogfood · AI agent
Modified
Oct 1, 2026, 21:23 UTC · Claude Baseline Pass · AI agent

Hazard review

Reviewed Oct 1, 2026, 21:26 UTCby agent:claude-baseline-passcatalog v1.11.0
  • scenarioreviewedmalformed_inputboundaryedge_caseinput_domain

    Clean-baseline review against upstream e332dc97 (2026-10-01). Upstream stripJsonc is two string-blind regex passes: a line-anchored pass drops each whole-line // comment with its line break, then a pass drops each comma whose next non-whitespace character is } or ]. Worst case: the comma pass also matches inside string literals, so a label or action carrying comma+closer ("x, ]y", mv f{.bak,}) is silently rewritten while the parse still succeeds (KI-MENU-JSONC-COMMA-IN-STRING, #13250); an inline // tail is not stripped, so JSON.parse rejects the file and the whole file contributes no rows (KI-MENU-JSONC-INLINE-COMMENT, #13493; docs/menu.md documents the limitation); block comments are not stripped (KI-MENU-JSONC-STRIP-GAPS). Within the documented grammar the order of the two passes is the control: a trailing comma followed by whole-line comments and then } or ] is dropped, so a commented-out entry after the last real one keeps every row (preservation tests in menu-test.sh and test/node/menumodel-replay.test.mjs, incl. the shipped extension template with its examples uncommented, and a 2000-case seeded differential property test). boundary: EOF without a trailing newline after a comment line is matched by (\n|$); a file that strips to whitespace yields []. edge_case: // inside a string survives because only line-leading comments are matched; CRLF comment lines are removed whole. Catalog 1.11.0 re-review: input_domain applied, input_domain is on its obligation checklist: LF, CRLF, comment indentation with any JS whitespace, any character inside strings and huge files are accepted; non-ASCII whitespace between tokens and CR-only files with a comment empty the menu (KI-MENU-JSONC-UNICODE-WHITESPACE, KI-MENU-JSONC-CR-LINE-ENDINGS). concurrency_scale not applicable, a pure function of its arguments, recomputed on each load or keystroke: no state across calls, no process, timer or lock.

  • propertyrevieweddeterminism

    The strip is a single left-to-right state-machine pass with two states (in-string, outside), so one input yields one output every time - the same authored file parses to the same entries on every load, including across the file watcher's reloads.

  • structuralnot applicable

    Character-classified string concatenation in a bounded single pass; no memory management, pointer math, or numeric surface, and no encoding transform - bytes pass through verbatim outside the two strip rules.

  • domainnot applicable

    The parser consumes the two fixed local menu JSONC paths (same-user, no egress sink in the traced files), and the parse-failure recovery policy (empty list, defaults preserved) is owned by the failure-arm siblings (3T3F/66FW), so no domain class binds to the strip contract reviewed here.

Change history

Every recorded revision of this requirement's source file — newest first, each with its commit message and the diff for that change.

Review history

Human and AI-agent approvals of this requirement — the 'why was this approved' lineage, each with the reviewer's justification and the code it cites.

  1. Kimi Zero Warnings · AI agentApprovedSpec conformanceSep 27, 2026 · 5 days agoREVIEW-48

    Read stripJsonc (the function this branch fixed). Full-line // comments are stripped first, then trailing commas are removed string-aware: commas inside string literals copy verbatim (with backslash-escape handling) and a comma outside strings is dropped only when the next non-whitespace char is } or ]. The jsonc_has_comments_or_commas condition models both transforms; the string-awareness is the 66FW decision closing DEFECT-260927-CMMA. Formula conforms to the code.

    Cited code (1)

Open known issues

Findings currently open against this requirement — issues its verification surfaced that are not resolved yet. Each links to the full finding.

Obligations

What this requirement must witness to be considered satisfied — the required evidence, and the tests that discharge each one.

Discharging tests pending a synced audit.

Formula evidence

The formal formula behind this requirement, the variables it is written over, and the tests that exercise it (each term is explained inline).

FRETish formula

when jsonc_has_comments_or_commas the menu_model shall eventually satisfy items_parsed

Witnesses· 3 scenarios total

  • menu-test.sh:1
    exercises 3 condition scenarios

MC/DC truth table· 3 rows

Each row assigns the formula's conditions (T/F) and shows the Result— the formula's value for that input row, not a test pass/fail. A row proves a condition when flipping only that condition flips the outcome. The test that covers each row is linked.

Covereda test exercises this rowExempteda reviewed mcdc:ignoreNo-actionfalse-result row satisfied by designUncoveredneeds a covering test
#items_parsedjsonc_has_comments_or_commasResultProvesCovering test
1FFTjsonc_has_comments_or_commas
2FTFitems_parsed
3TTTitems_parsed

Its place

How this requirement connects — what proves it, what it affects, and what it rests on. Authored links only here; automatically derived links come from the audit index.

Loading graph…

Trace evidence

The concrete artifacts linked to this requirement — implementing code, verifying tests, documents, and the findings raised against it.

Impact

Blast radius — authored trace links only (automatically derived links come from the audit index and aren't shown here).

If you change this

Nothing downstream depends on this yet

No downstream impact — "The parser strips full-line // comments and trailing commas…" has no downstream edges.

What this rests on

Discussions

Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.

Sign in to discuss this with the proof team.Sign in