Proof Portal

Project overview

Omarchy

ProbeLabsviewing a historical run

A proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.

Viewing historical run 89b2c1eSep 29, 2026, 09:42 AMpr/9056Back to current
All requirements
RequirementSW-REQ-260922-FGZQSoftwareReview

finishRequest with a selection writes the value to the selection file and creates the done file, shell-quoted, and only then closes.

This requirement changed after its last recorded review, so approval is stale. Automated checks pass.
PriorityshallTypeguaranteeCategoryfunctionalComponentmenuAssuranceCFindingsnone open

Specification

The requirement exactly as authored — its complete prose text and, where present, the formal FRETish sentence it compiles to.

Description

finishRequest with a selection writes the value to the selection file and creates the done file, shell-quoted, and only then closes.

FRETish formula
when finish_requested the dmenu_protocol shall eventually satisfy selection_and_done_written
View full formal model

Rationale & tags

Why this requirement exists, and how it is categorised.

Menu.qml finishRequest lines 131-149 (selection branch 145-147).

Verification & provenance

How this requirement was checked: the review trail, edit history, and the machine-analysis status terms (each ⓘ explains what it means).

Assurance levelC
Formalizationvalid
Realizabilityrealizable
Vacuitychecked_ok
Strategyfretish

Review

Status
in_review
Reviewer
Kimi Upstream Refresh · AI agent
Reviewed
Sep 25, 2026, 09:20 UTC

History

Created
Sep 22, 2026, 13:34 UTC · Kimi Dogfood · AI agent
Modified
Sep 25, 2026, 09:21 UTC · Kimi Upstream Refresh · AI agent

Hazard review

Reviewed Sep 25, 2026, 09:32 UTCby agent:kimi-upstream-refreshcatalog v1.10.0
  • scenarioreviewedconcurrent

    Concurrent-summon interleaving reviewed for PR#9056: this finishRequest/lifecycle path is now reachable from open()'s new requestActive guard (SW-REQ-260925-XTGG); behavior on that path is the already-specified null/cancel semantics, so no new hazard. finishRequest remains reentrant-safe: state captured then cleared before the write.

  • domainnot applicable

    Domain classes fire only on matching workload tags (HTTP/crypto/IPC frameworks); these menu dmenu-protocol requirements carry no domain tags and the component is a local QML plugin + bash scripts with no network/crypto surface.

  • structuralnot applicable

    Structural classes target C-family memory/format-string hazards (pointer arithmetic, manual ownership, sanitizer evidence). Implementation is QML/JS (GC'd) plus bash invoking printf with constant format strings; no manual memory or binary framing exists in this component.

  • propertyreviewedatomicity

    Selection answer is one proc invocation (printf selection > selectionFile; : > doneFile): done file is only created after the selection write in the same shell command, so the polling caller never observes done-without-selection. Captured-then-cleared state prevents double answers.

Change history

Every recorded revision of this requirement's source file — newest first, each with its commit message and the diff for that change.

Review history

Human and AI-agent approvals of this requirement — the 'why was this approved' lineage, each with the reviewer's justification and the code it cites.

  1. Kimi Upstream Refresh · AI agentApprovedSpec conformanceSep 25, 2026 · last weekREVIEW-24

    Read finishRequest (Menu.qml:131-149). The selection branch (Menu.qml:145-147) runs 'printf %s\n <selection> > selectionFile; : > doneFile' with both paths Util.shellQuote'd, then resultProc.running=true - exactly selection_and_done_written after finish_requested with a non-null selection. State (paths) is captured before being cleared (137-141) so the write targets the active request's files. The menu closes via opened=false in the callers (applyDmenuSelection Menu.qml:879-884 sets opened=false before finishRequest). No silent gating the formula misses.

    Cited code (1)

Obligations

What this requirement must witness to be considered satisfied — the required evidence, and the tests that discharge each one.

The tests that discharge each obligation aren't available for a historical run

The evidence matrix behind each obligation comes from the live audit index, which can't be rebuilt for a past commit. Nothing here means unknown — not that the requirement has no obligations.

Formula evidence

The formal formula behind this requirement, the variables it is written over, and the tests that exercise it (each term is explained inline).

FRETish formula

when finish_requested the dmenu_protocol shall eventually satisfy selection_and_done_written

Witnesses· 3 scenarios total

  • menu-dmenu-test.sh:1
    exercises 3 condition scenarios

MC/DC truth table· 3 rows

Each row assigns the formula's conditions (T/F) and shows the Result— the formula's value for that input row, not a test pass/fail. A row proves a condition when flipping only that condition flips the outcome. The test that covers each row is linked.

Covereda test exercises this rowExempteda reviewed mcdc:ignoreNo-actionfalse-result row satisfied by designUncoveredneeds a covering test
#finish_requestedselection_and_done_writtenResultProvesCovering test
1FFTfinish_requested
2TFFfinish_requested
3TTTselection_and_done_written

Its place

How this requirement connects — what proves it, what it affects, and what it rests on. Authored links only here; automatically derived links come from the audit index.

Loading graph…

Trace evidence

The concrete artifacts linked to this requirement — implementing code, verifying tests, documents, and the findings raised against it.

No findings affect this requirement

Nothing was flagged against this requirement in the pinned run.

Impact

Blast radius — authored trace links only (automatically derived links come from the audit index and aren't shown here).

If you change this

Nothing downstream depends on this yet

No downstream impact — "finishRequest with a selection writes the value to the…" has no downstream edges.

What this rests on

Discussions

Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.

Sign in to discuss this with the proof team.Sign in