Proof Portal

Project overview

Omarchy

ProbeLabsviewing a historical run

A proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.

Viewing historical run f7291a5Oct 2, 2026, 07:42 PMpr/14054Back to current
All requirements
RequirementSW-REQ-260922-FGZQSoftwareReview

finishRequest with a selection writes the value to the selection file and creates the done file, shell-quoted, and only then closes.

This requirement changed after its last recorded review, so approval is stale. Automated checks pass.
PriorityshallTypeguaranteeCategoryfunctionalComponentmenuAssuranceCFindingsLowworst open

Specification

The requirement exactly as authored — its complete prose text and, where present, the formal FRETish sentence it compiles to.

Description

finishRequest with a selection writes the value to the selection file and creates the done file, shell-quoted, and only then closes.

FRETish formula
when finish_requested the dmenu_protocol shall eventually satisfy selection_and_done_written
View full formal model

Rationale & tags

Why this requirement exists, and how it is categorised.

Menu.qml finishRequest lines 117-135.

Verification & provenance

How this requirement was checked: the review trail, edit history, and the machine-analysis status terms (each ⓘ explains what it means).

Assurance levelC
Formalizationvalid
Realizabilityrealizable
Vacuitychecked_ok
Strategyfretish

Review

Status
in_review
Reviewer
Kimi Zero Warnings · AI agent
Reviewed
Sep 27, 2026, 21:25 UTC

History

Created
Sep 22, 2026, 13:34 UTC · Kimi Dogfood · AI agent
Modified
Sep 27, 2026, 21:25 UTC · Kimi Zero Warnings · AI agent

Hazard review

Reviewed Oct 1, 2026, 21:26 UTCby agent:claude-baseline-passcatalog v1.11.0
  • scenarioreviewedboundaryconcurrentedge_caseconcurrency_scale

    Worst case: the caller's read races the write - the done marker landing before the selection bytes are durable converts a real pick into a spurious cancel (the CLI exits 1 on an empty selection), or a late answer for an already-finished request writes into the next invocation's files; the single bash -c ordering (selection flushed, then done truncated) is the commit protocol and the up-front field clearing plus the activeSelection/activeDone locals pin the write to this request's mktemp-unique paths. boundary: the null-selection dismissal arm versus the answered arm is the exact partition this requirement sits on the answered side of (done-only is C8HX). concurrent: the single-threaded QML loop plus the requestActive re-check make a second finish a silent no-op rather than a duplicate write. edge_case: a selection with newlines or shell metacharacters passes verbatim through Util.shellQuote into printf - the caller receives exactly what was picked, multi-line included, and the quoting helper's own requirements own its correctness; the polling CLI side and its unbounded wait are the Q6ZS/9ABD siblings' tracked debt. Catalog 1.11.0 re-review: input_domain not applicable, it reads no external text input. concurrency_scale applied, part of the menu request lifecycle: the answer write can race a superseding summon.

  • propertyreviewedatomicity

    Answer delivery is all-or-nothing against the polling caller: the done file exists only after the selection file is fully written inside the same bash -c, so observing done implies a complete selection or a deliberate dismissal - no interleaving leaves the caller reading a truncated answer.

  • structuralnot applicable

    One shell-quoted printf through a spawned bash -c; no parsing, arithmetic, memory, or encoding transform - selection bytes are quoted and passed verbatim.

  • domainnot applicable

    Same-user mktemp'd files written by the menu's own result process; summon-payload path provenance is Q6ZS's, the CLI wait and its no-deadline poll are the tracked Q6ZS/9ABD debt, and no network, crypto, or privilege boundary is crossed in the write arm.

Change history

Every recorded revision of this requirement's source file — newest first, each with its commit message and the diff for that change.

Review history

Human and AI-agent approvals of this requirement — the 'why was this approved' lineage, each with the reviewer's justification and the code it cites.

  1. Kimi Zero Warnings · AI agentApprovedSpec conformanceSep 27, 2026 · 5 days agoREVIEW-50

    Read finishRequest. Past the no-active-request guard, a selection is written shell-quoted to the selection file, the done file is created, and only then opened=false closes the menu — the write pair precedes the close, as the description states. finish_requested models the guarded main path (the early return is 3VTN's condition). Formula conforms to the code.

    Cited code (1)
  2. Kimi Upstream Refresh · AI agentApprovedSpec conformanceSep 25, 2026 · last weekREVIEW-78

    Read finishRequest (Menu.qml:131-149). The selection branch (Menu.qml:145-147) runs 'printf %s\n <selection> > selectionFile; : > doneFile' with both paths Util.shellQuote'd, then resultProc.running=true - exactly selection_and_done_written after finish_requested with a non-null selection. State (paths) is captured before being cleared (137-141) so the write targets the active request's files. The menu closes via opened=false in the callers (applyDmenuSelection Menu.qml:879-884 sets opened=false before finishRequest). No silent gating the formula misses.

    Cited code (1)

Open known issues

Findings currently open against this requirement — issues its verification surfaced that are not resolved yet. Each links to the full finding.

Obligations

What this requirement must witness to be considered satisfied — the required evidence, and the tests that discharge each one.

The tests that discharge each obligation aren't available for a historical run

The evidence matrix behind each obligation comes from the live audit index, which can't be rebuilt for a past commit. Nothing here means unknown — not that the requirement has no obligations.

Formula evidence

The formal formula behind this requirement, the variables it is written over, and the tests that exercise it (each term is explained inline).

FRETish formula

when finish_requested the dmenu_protocol shall eventually satisfy selection_and_done_written

Witnesses· 3 scenarios total

  • menu-dmenu-test.sh:1
    exercises 3 condition scenarios

MC/DC truth table· 3 rows

Each row assigns the formula's conditions (T/F) and shows the Result— the formula's value for that input row, not a test pass/fail. A row proves a condition when flipping only that condition flips the outcome. The test that covers each row is linked.

Covereda test exercises this rowExempteda reviewed mcdc:ignoreNo-actionfalse-result row satisfied by designUncoveredneeds a covering test
#finish_requestedselection_and_done_writtenResultProvesCovering test
1FFTfinish_requested
2TFFfinish_requested
3TTTselection_and_done_written

Its place

How this requirement connects — what proves it, what it affects, and what it rests on. Authored links only here; automatically derived links come from the audit index.

Loading graph…

Trace evidence

The concrete artifacts linked to this requirement — implementing code, verifying tests, documents, and the findings raised against it.

Impact

Blast radius — authored trace links only (automatically derived links come from the audit index and aren't shown here).

If you change this

Nothing downstream depends on this yet

No downstream impact — "finishRequest with a selection writes the value to the…" has no downstream edges.

What this rests on

Discussions

Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.

Sign in to discuss this with the proof team.Sign in