Proof Portal

Project overview

Omarchy

ProbeLabsviewing a historical run

A proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.

Viewing historical run 60420e2Oct 2, 2026, 04:51 AMpr/13012Back to current
All requirements
RequirementSW-REQ-260929-THMBSoftwareReview

The pipeline detects video paths by extension and dispatches each media file to a format-appropriate converter.

This requirement changed after its last recorded review, so approval is stale. Automated checks pass and 0/1 obligations are satisfied.
PriorityshallTypeguaranteeCategoryfunctionalComponentmenuAssuranceCFindingsMediumworst open

Specification

The requirement exactly as authored — its complete prose text and, where present, the formal FRETish sentence it compiles to.

Description

The pipeline detects video paths by extension and dispatches each media file to a format-appropriate converter. Videos go to ffmpegthumbnailer under a timeout; still images go to single-threaded vipsthumbnail. A lazy open generates stills inside the menu process and queues videos for the fan-out. The queued fan-out fills every core with still images and gives videos one lane per four cores. A content-hash lock serializes the generators per file; the generator reaps an aged legacy directory lock and leaves a fresh one to its owner. The finished thumbnail lands at the content-hash cache path and its row serves it.

FRETish formula
when thumbnail_missing the image_selector shall eventually satisfy thumbnail_generated
View full formal model

Rationale & tags

Why this requirement exists, and how it is categorised.

bin/omarchy-menu-images is_video_path, generate_thumbnail, thumbnail_for, and drain_pending_thumbnails carry the thumbnail pipeline between the directory scan and the row cache. Authored with SW-REQ-260929-REJT to resolve the family_under_modeled finding on the shared target.

Verification & provenance

How this requirement was checked: the review trail, edit history, and the machine-analysis status terms (each ⓘ explains what it means).

Assurance levelC
Formalizationvalid
Realizabilityrealizable
Vacuitychecked_ok
Strategyfretish

Review

Status
in_review
Reviewer
Opencode · AI agent
Reviewed
Sep 30, 2026, 00:40 UTC

History

Created
Sep 30, 2026, 00:16 UTC · Opencode · AI agent
Modified
Sep 30, 2026, 08:02 UTC · Leonid Bugaev

Hazard review

Reviewed Oct 1, 2026, 21:26 UTCby agent:claude-baseline-passcatalog v1.11.0
  • scenarioreviewedmalformed_inputboundaryedge_caseconcurrency_scale

    Worst case: a directory whose stills all stall vips wedges every nproc lane and the preload drain never returns, so the image picker never opens. malformed_input: a vanished file or unparsable image fails its stat/converter guard and is skipped or queued without a row (thumbnail_for stat guard, generator failure arms); hashes are md5 of path+size+mtime, so hostile bytes never steer control flow. boundary: the legacy directory-lock reap fires only past 120s and only when the path is still a directory, and a fresh legacy lock makes the exec redirect fail so the generator bails rather than clobbering a live owner. edge_case: timeout(124) and SIGKILL(137) converter exits deliberately write no rejection marker so the next open retries, while any other non-zero exit records one - the asymmetry is the documented retry policy. Catalog 1.11.0 re-review: input_domain not applicable, media files are handed to converters by extension; their contents are not parsed here. concurrency_scale applied, lazy and queued generation run concurrently, serialized per file on a content-hash lock.

  • propertyreviewedidempotency

    idempotency: regenerating a thumbnail for an unchanged file converges on the same content-hash path; a completed thumbnail short-circuits the generator, and a mid-write crash leaves only the pid-suffixed temp that the next lock holder sweeps (rm of thumbnail.*.jpg under the lock), so retries repair rather than accumulate. determinism: fan-out order across nproc lanes is unspecified by the req (rows are pruned against existence, not generation order), so lane scheduling is not an invariant this contract carries. atomicity of the cache publish (write-temp-rename under the rows lock) is owned by the sibling cache-discipline reqs 43HQ/MH9B and already reviewed there.

  • structuralnot applicable

    bash plus external converters: no manual memory, pointer arithmetic, or format strings; the only encoding surface (base64 row transit to the shell picker) belongs to the open-flow siblings 43HQ/MH9B, not to the generation contract this req carries. The nil/empty edge (stat guard returns empty and the caller skips) is recorded under scenario.

  • domainreviewed

    external_call_timeout_bounded evaluated and DEFERRED (see obligation_deferrals): the still lane vipsthumbnail call has no deadline and a stalled conversion wedges its lane - in preload mode the synchronous drain then blocks the picker open, in lazy mode each open leaks an orphaned vipsthumbnail child. Filed as KI-MENU-IMAGES-VIPS-NO-TIMEOUT; this is the batch D headline hazard. The remaining external surfaces are bounded: ffmpegthumbnailer under timeout -k 5 10, both flock waits bounded at 30s, and the done_file poll in the open flow is a poll-loop mechanism already deferred on SW-REQ-260922-MH9B under KI-MENU-SELECT-POLL-DEADLOCK (generation does not own that wait). cache_coherent: thumbnails key on path+size+mtime, so an edited image regenerates on next open and a repaired video starts clean - stale-cache serving needs an identical signature. The append-only index.tsv grows one ~100-byte row per new-or-changed file with no cap; accumulation_bounded is gated out of this project profile and the growth is desktop-churn bounded, recorded here as an explicitly evaluated residual rather than a new obligation.

Change history

Every recorded revision of this requirement's source file — newest first, each with its commit message and the diff for that change.

Review history

Human and AI-agent approvals of this requirement — the 'why was this approved' lineage, each with the reviewer's justification and the code it cites.

  1. Opencode · AI agentApprovedSpec conformanceSep 30, 2026 · 3 days agoREVIEW-260930-WJQK

    Read the full pipeline in bin/omarchy-menu-images. is_video_path (157) matches case-insensitive video extensions. generate_thumbnail (165-222) reaps a legacy directory lock only after 120s, refuses a fresh one, serializes under flock -w 30, clears stale partial tmps, dispatches video to timeout -k 5 10 ffmpegthumbnailer and stills to single-threaded vipsthumbnail, and moves the finished file into the content-hash path. thumbnail_for (225-270) resolves the index hash, serves a cached thumbnail, or routes to the lazy lane (stills, in-process background) or the queued lanes. drain_pending_thumbnails (278-295) fans stills out over nproc and videos over nproc/4 with a floor of one. Formula: a missing thumbnail settles by generation at its content-hash path; every scanned file routes through thumbnail_for, so no generation path is missed.

    Cited code (5)

Open known issues

Findings currently open against this requirement — issues its verification surfaced that are not resolved yet. Each links to the full finding.

Obligations

What this requirement must witness to be considered satisfied — the required evidence, and the tests that discharge each one.

1 obligation · 1 deferred

Browse the catalogue
Deferred

Every cross-process call shall declare connect, read, and total deadlines; no external call is defaulted to "no timeout."

Worst case if violatedMedium

vipsthumbnail runs with no timeout wrapper: a still image that stalls vips (corrupt/pathological file, stalled mount) wedges its fan-out lane forever; in --preload mode drain_pending_thumbnails runs before the picker opens, so enough wedged stills block the image picker open, and lazy opens leak one orphaned vipsthumbnail per open into the menu process

the video lane is bounded (timeout -k 5 10 ffmpegthumbnailer) but the still lane is not; a stalled vips wedges its lane indefinitely and in preload mode blocks the picker open; filed as KI-MENU-IMAGES-VIPS-NO-TIMEOUT with the fix shape (timeout wrapper or async kill) — tracked debt, not an accepted gap

Discharging evidence0/1 required witnessed
  • nominalrequireddeferred
    Witnessing deferred — accepted while the tracking known issue stays open.

Formula evidence

The formal formula behind this requirement, the variables it is written over, and the tests that exercise it (each term is explained inline).

FRETish formula

when thumbnail_missing the image_selector shall eventually satisfy thumbnail_generated

Witnesses· 2 scenarios total

  • menu-images-test.sh:1
    exercises 2 condition scenarios

MC/DC truth table· 3 rows

Each row assigns the formula's conditions (T/F) and shows the Result— the formula's value for that input row, not a test pass/fail. A row proves a condition when flipping only that condition flips the outcome. The test that covers each row is linked.

Covereda test exercises this rowExempteda reviewed mcdc:ignoreNo-actionfalse-result row satisfied by designUncoveredneeds a covering test
#thumbnail_generatedthumbnail_missingResultProvesCovering test
1FFTthumbnail_missing
2FTFthumbnail_generated—
3TTTthumbnail_generated

Its place

How this requirement connects — what proves it, what it affects, and what it rests on. Authored links only here; automatically derived links come from the audit index.

Loading graph…

Trace evidence

The concrete artifacts linked to this requirement — implementing code, verifying tests, documents, and the findings raised against it.

Impact

Blast radius — authored trace links only (automatically derived links come from the audit index and aren't shown here).

If you change this

Requirements
0
Files
1
Tests
1
At-risk contracts
0

Files to re-check (1)

  • omarchy-menu-imagesbin/omarchy-menu-images

Tests to re-run (1)

  • menu-images-test.shtest/shell.d/menu-images-test.sh

What this rests on

Discussions

Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.

Sign in to discuss this with the proof team.Sign in