Proof Portal

Project overview

Omarchy

ProbeLabsviewing a historical run

A proof layer — requirements, tests and verified fixes — for two of Omarchy's subsystems: the application menu (launcher scripts, QML model, JSONC config, search and selection) and the lock screen (lock scripts, QML, PAM authentication). Scope is deliberately limited to those components of omacom/omarchy; the rest of the distribution is not covered.

Viewing historical run 199d112Oct 2, 2026, 02:38 AMquattro-proofBack to current
All requirements
RequirementSYS-REQ-260922-PPDWSystemReview

The default JSONC and the user extension merge into one ordered item tree: per-key user overrides, stable order, inferred kinds and parents, injected root.

This requirement changed after its last recorded review, so approval is stale. Automated checks pass and 3/3 obligations are satisfied.
PriorityshallTypeguaranteeCategoryfunctionalComponentmenuAssuranceCFindingsnone open

Specification

The requirement exactly as authored — its complete prose text and, where present, the formal FRETish sentence it compiles to.

Description

The default JSONC and the user extension merge into one ordered item tree: per-key user overrides, stable order, inferred kinds and parents, injected root.

FRETish formula
when menu_sources_loaded the menu_model shall eventually satisfy item_tree_merged
View full formal model

Rationale & tags

Why this requirement exists, and how it is categorised.

The merge defines what the menu shows; a lost or duplicated row here is user-visible on every open.

Verification & provenance

How this requirement was checked: the review trail, edit history, and the machine-analysis status terms (each ⓘ explains what it means).

Assurance levelC
Formalizationvalid
Realizabilityrealizable
Vacuitychecked_ok
Strategyfretish

Review

Status
in_review
Reviewer
Kimi Zero Warnings · AI agent
Reviewed
Sep 27, 2026, 21:25 UTC

History

Created
Sep 22, 2026, 13:33 UTC · Kimi Dogfood · AI agent
Modified
Sep 30, 2026, 08:08 UTC · Leonid Bugaev

Hazard review

Reviewed Oct 1, 2026, 21:26 UTCby agent:claude-baseline-passcatalog v1.11.0
  • scenarioreviewedmalformed_inputboundaryinput_domainconcurrency_scale

    Worst case graded above (whole-user-extension silent drop on one malformed key - low: documented recovery, menu stays usable on defaults, and the fix is one lint pass; graded low because the failure is total but benign). malformed_input: the parser declares its policy - whole-line comments and trailing commas are stripped before JSON.parse, unparsable text catches to [], scalar and null roots are treated as no rows (an array root is walked with for..in and renders phantom rows keyed 0,1,... - KI-MENU-JSONC-ARRAY-ROOT, #13492), and non-object entries are skipped during normalization, so malformed shape can never enter the tree. boundary: an empty file yields [] with the injected root, and a user override for an unknown key still merges (per-key override semantics do not require the key to exist upstream). Catalog 1.11.0 re-review: input_domain applied, it merges the default and user menu files, whose byte-level domain is stated and witnessed on SW-REQ-260922-E4J2 and SW-REQ-260922-3T3F. concurrency_scale applied, the two FileView loads finish in either order and each rebuilds the tree, so the merged tree must not depend on their order.

  • propertyreviewedinvariant_preservation

    invariant_preservation: the merge rebuilds fresh items/itemOrder objects on every pass and never writes into the QML var properties it is handed (the documented engine dropped-write defect behind the historical duplicate-row bug), so merge is idempotent and rerun-safe, kind/parent inference is a pure function of the entry shape, and the root is injected exactly once. determinism: default-then-user source order fixes override precedence; equal-priority conflicts resolve last-writer-wins deterministically.

  • structuralnot applicable

    JS objects under a GCd engine: no manual memory, pointer arithmetic, or format-string surface; the JSONC stripper is two string-blind regex passes (string-literal gaps tracked as KI-MENU-JSONC-COMMA-IN-STRING), and malformed text is dispositioned under scenario.malformed_input (catch to []). No nil deref: every entry passes the object-shape guard before normalization.

  • domainnot applicable

    the user menu config is the trust root for its own session (same disposition as the keybinding Lua review): merging it cannot cross a privilege boundary, and app/provider rows land through their own children with their own hazard decisions. No external call, timeout, or concurrency surface in the merge itself (single synchronous function per merge). cross_structure_key_identity is met by construction - the map is keyed by the same id string that normalizeItem stamps into entry.id, so key and identity cannot drift.

Change history

Every recorded revision of this requirement's source file — newest first, each with its commit message and the diff for that change.

Obligations

What this requirement must witness to be considered satisfied — the required evidence, and the tests that discharge each one.

2 obligations · 2 discharged

Browse the catalogue

Evidence tagged via <REQ> is witnessed by a requirement that satisfies this one — normal for stakeholder / aggregate requirements, which are proven through the requirements that refine them.

Discharged

Behavior at limits, thresholds, and edge-of-range values.

Discharging evidence1/1 required witnessed
Discharged

Behavior when operations fail or dependencies are unavailable.

If it were violatedLow

one syntax slip in the user menu JSONC (unbalanced brace a hundred rows in) silently drops the ENTIRE user extension for that session: parseMenuJsonc catches and returns [], the menu renders defaults only, and no diagnostic anywhere tells the user their customization was discarded - fail-visible only by absence, recovery documented but undiscoverable

Discharging evidence2/2 required witnessed

Formula evidence

The formal formula behind this requirement, the variables it is written over, and the tests that exercise it (each term is explained inline).

FRETish formula

when menu_sources_loaded the menu_model shall eventually satisfy item_tree_merged

Witnesses· 2 scenarios total

  • menu-test.sh:1
    exercises 2 condition scenarios

MC/DC truth table· 3 rows

Each row assigns the formula's conditions (T/F) and shows the Result— the formula's value for that input row, not a test pass/fail. A row proves a condition when flipping only that condition flips the outcome. The test that covers each row is linked.

Covereda test exercises this rowExempteda reviewed mcdc:ignoreNo-actionfalse-result row satisfied by designUncoveredneeds a covering test
#item_tree_mergedmenu_sources_loadedResultProvesCovering test
1FFTmenu_sources_loaded
2FTFitem_tree_mergedExempted · defensive — mergeMenuSources always returns the rebuilt items/order map; loaded sources without a merged tree needs the build loop removed (reviewed: REVIEW-M8)
3TTTitem_tree_merged

Its place

How this requirement connects — what proves it, what it affects, and what it rests on. Authored links only here; automatically derived links come from the audit index.

Loading graph…

Trace evidence

The concrete artifacts linked to this requirement — implementing code, verifying tests, documents, and the findings raised against it.

No findings affect this requirement

Nothing was flagged against this requirement in the pinned run.

Impact

Blast radius — authored trace links only (automatically derived links come from the audit index and aren't shown here).

If you change this

Requirements
5
Files
2
Tests
3
At-risk contracts
0

Files to re-check (2)

  • Menu.qmlshell/plugins/menu/Menu.qml
  • MenuModel.jsshell/plugins/menu/MenuModel.js

Tests to re-run (3)

  • menumodel-replay.test.mjstest/node/menumodel-replay.test.mjs
  • menu-test.shtest/shell.d/menu-test.sh
  • menu-pointer-lifecycle-test.shtest/shell.d/menu-pointer-lifecycle-test.sh

What this rests on

Discussions

Discuss this with the proof team. Nothing changes in your audit automatically — you open a request and a staff member records any outcome inside the thread.

Sign in to discuss this with the proof team.Sign in